otwcode/otwarchive

* AO3-5023 Add tests for wrangling within a fandom

* AO3-5023 Fix broken links in wrangling sidebar

* AO3-5023 Test that a user can claim works that weren't automatically associated with their account

* AO3-5023 Fix broken route for claiming imported works

* AO3-5023 Update to new Ruby hash syntax  in path definition

* Reset email

* AO3-5023 Tweak wording of email queue clearing step

* AO3-5023 Update finders in skin and admin rake files and make sure we're using find_each instead of all, which loads all the things into memory

* AO3-5023 Uncomment a line in the admin task that I temporarily commented out to avoid actually destroying any accounts in my dev environment

* AO3-5023 Change taggings_counts back to taggings_count, since I have no idea where that change came from

…e layout (#2944)

…eadings and admin posts (#2945)

* AO3-4946 Expand challenge assignment test

* AO3-4946 review comments

* AO3-5023 Fix syntax on recent bookmarks

* AO3-5023 Add test for Show Most Recent Bookmark button

* AO3-5023 Some troubleshooting for the test

* AO3-5023 Forcing another JavaScript test to fail on a 'I should see' step so I can compare it to the relevant test

* AO3-5023 Revert temporarily-forced failure in tag set tests

* AO3-5023 Try using a specific selector in the show recent bookmarks test

* AO3-5023 Get rid of the failing 'I should see' steps

* AO3-5023 Make sure the JavaScript is loading

* AO3-5023 Undo JavaScript changes now that I see the JavaScript is loading

* AO3-5023 Temporarily remove style that hides the Show Most Recent Bookmark link

* AO3-5023 Restore the style I temporarily removed, and include some spacing, quotation mark, and hash rocket fixes in views/bookmarks/_bookmark_blurb

* AO3-5023 Got overzelous with my tidying of the bookmark blurb -- url_for should not become path_for

* AO3-5023 Add a step to expire the bookmark count  cache

* AO3-5023 And now we make sure the cache is expiring

* AO3-5023 Put the bookmark count for troubleshooting

* AO3-5023 Try expiring the cache for the entire bookmark page as well

* AO3-5023 Try running the statistics rake task before accessing the bookmark page

* AO3-5023 Try running the rake and expiring the stats cache

* AO3-5023 We will now entertain the possibility the bookmarks don't exist

* AO3-5023 Let's try updating the indexes in addition to running the stats task and expiring the caches

* AO3-5023 Fix getting the number of bookmarks by counting the actual items

* AO3-5023 Put the stats task and the search index updating in the steps, add some more puts to get more information for troubleshooting

* AO3-5023 Remove work.touch from cache expiration  step to see if it's necessary

* AO3-5023 Tests for using Show Most Recent Bookmarks on the bookmarks index

* AO3-5023 Go back to the simplest way of doing things now that the test works

* AO3-5023 There's a k in 'bookmarks' and I can remove the half-deleted step

Before each unit test, clear memcached, Redis, and Elasticsearch.

* Adds specs to catch approved_collections bug

* Fixes bug where collection names show up multiple times on work/collections page

* Removes useless test file

* Fixes bug with AR query in collections controller

* Fixes problem with includes :approved_collections elsewhere in works controller

* Fixes artificial narrowing of works included in @works variables in 2
controllers

* AO3-4947 Expanding collection item test

* AO3-4947 changing variable names

* AO3-4947 Typos and review comments

* AO3-4947 testing controller not just views

* AO3-4947 typo

* AO3-4947 next attempt

* AO3-4947 last review comments

* AO3-4947 trying again

* AO3-4947 trying again

* AO3-4947 trying again

* AO3-4947 typo

* AO3-4947 review comments

* AO3-5023 Fix disabling of post w/o preview on chapter form

* AO3-5023 Fix disabling of post button on chapter preview form

* AO3-5023 Fix spacing issue I created when fixing disable option on chapter preview's post form

* AO3-5023 Quotation mark, hash rocket, and line lengh clean up in views/chapters/preview.html.erb

* AO3-5023 Fix disabling send button on support form

* AO3-5023 Quotation mark changes on views/feedbacks/new.html.erb

* AO3-5023 Fix disabling post w/o preview button on new work form

* Fix disabled post button on work preview page

* AO3-5023 Quotation mark, partial syntax, hash rocket, and space style fixes for views/works/preview

* AO3-5023 Delete stray space at end of line in views/chapters/preview

* AO3-5023 Fix deletion confirmation message for admins deleting works, bookmarks, and external works

* AO3-5023 Fix confirmation message for dleleting admin posts (news) from the edit page and the post itself

* AO3-5023 Line length and quotation mark changes for views/admin/_admin_nav and views/admin_posts/show

* AO3-5023 Fix deletion confirmation popup when destroying all spammer creations

* AO3-5023 Fix confirmation popup when removing blacklisted email

* AO3-5023 Quotation mark and line length tweaks to views/admin/blacklisted_emails/index

* AO3-5023 Fix confirmation popup when defaulting all incomplete assignments or purging all assignments for a challenge

* AO3-5023 Fix confirmation popup when a collection member leaves the collection

* AO3-5023 Fix confirmation popup when deleting an invite request

* AO3-5023 Fix typo when fixing confirmation popup when deleting an invite request

* AO3-5023 Quotation mark and line length changes to views/invite_requests/manage

* AO3-5023 Fix deletion confirmation popup for deleting a skin

* AO3-5023 Quotation mark and line length changes for views/skins/_skin_actions

* AO3-5023 Fix confirmation popup when changing username

* AO3-5023 Quotation mark changes to views/users/change_username

* AO3-5023 Fix confirmation popup when removing parent work from work edit form

* Remove warnings

* Change validation

* Back out of changes config.active_record.raise_in_transactional_callbacks

* Fix the secrets file

* AO3-5017 Simplify work search submit selector

* AO3-5017 Update test description and remove a code comment that lied

* AO3-5017 Correct and expand scenarios related to searching for anonymous works, which previously and incorrectly stated they were testing *unrevealed* works

* AO3-5017 Fix missing quotation mark in search for works by Anonymous test

* AO3-5017 Refactor work search steps and remove unused steps

* AO3-5017 Check the results of the searches

* AO3-5017 Fix typo in checking word count results

* AO3-5017 Factory for posted works

* AO3-5017 Add tests for relationship and freeform searches, and start making test data for character searches

* AO3-5017 Fix two missing colons in 'You searched for'

* AO3-5017 Some character tests and an atempt at improving the check of search results

* AO3-5017 Fix test for relationship tags with threesomes

* AO3-5017 Actually fix the relationship search test and add tests for category search

* AO3-5017 Fix expected number of results for relationship search in header

* AO3-5017 Define step for checking that results don't contain a category

* AO3-5017 Test searching and sorting by comments

* AO3-5017 Add tests for searching by fandom

* AO3-5017 Add code comment to explain why we don't use factories to make the works with comments for testing search

* AO3-5017 Update work index when creating works for fandom search test

* AO3-5017 Test searching and sorting by bookmarks

* AO3-5017 Fix a typo in a scenario and add some line breaks to scenarios

* AO3-5017 Fix typo in step for creating works with bookmarks for searching

* AO3-5017 Comment out bookmark tests that are failing due to blurb caching

* AO3-5017 Tests for searching by rating

* AO3-5017 Warning search test

* AO3-5017 Try to clarify what is being tested

* AO3-5017 Test searching with restricted, hidden, and draft works

* AO3-5017 Check for a specific syn in a relationship search test, time travel in our bookmark search test to avoid a caching issue, and add indexing steps and spacing to the work search steps

* AO3-5017 Separate the search features into a different folder

* AO3-5017 Undo change to show the the page step

* AO3-5017 Fix test that was looking for the wrong synonym and not specifying it was a relationship

* AO3-5017 Syntax changes to work search steps

* Ao3-5017 Force expiration of stats line in blurb when testing bookmark search results

* AO3-5017 Try moving the stats cache expiration into the bookmarking step itself and modify the tests temporarily to help check if it's really blurb caching

* Revert "AO3-5017 Try moving the stats cache expiration into the bookmarking step itself and modify the tests temporarily to help check if it's really blurb caching"

This reverts commit 65398ba.

* AO3-5017 Try expire_fragment for work blurb stats

AO3-5023 Allow resque tasks to start

Add test for AO3-2251.

AO3-5032 update from hash rocket syntax to JSON style

* Updates Rails to 4.2.8

* Updates path strings to start with leading slash

As of 4.2 `get/post/patch/delete` methods in integration tests require a leading
slash in order to build a valid URI

* Updates outdated `count` usage - `count` no longer accepts params

* Adds temp fix for problem with Nokogiri escape process

RackTest driver doesn't correctly handle css attribute selectors with escape
sequences

teamcapybara/capybara#1866

Capybara expects to find ">" on the page, but ">" is ">" which gets read
as ">" instead of ">".

* Fixes remaining breaking unicode character refs in works search feature

* Update ignore list

* Restore features/works/work_search.feature

* Updates Rails to 4.2.8

* Updates path strings to start with leading slash

As of 4.2 `get/post/patch/delete` methods in integration tests require a leading
slash in order to build a valid URI

* Updates outdated `count` usage - `count` no longer accepts params

* Adds temp fix for problem with Nokogiri escape process

RackTest driver doesn't correctly handle css attribute selectors with escape
sequences

teamcapybara/capybara#1866

Capybara expects to find ">" on the page, but ">" is ">" which gets read
as ">" instead of ">".

* Fixes remaining breaking unicode character refs in works search feature

* AO3-5023 Add html_safe to the search summary to prevent > and < showing on the search results page; update the work search test to reflect this change

* AO3-5022 Bump Rails to 4.1.16

* AO3-5022 Remove with_scope on Work model

* AO3-5022 Bump Authlogic version

* AO3-5022 Bump to Authlogic 3.4.6

* AO3-5022 Resolve old association syntax for archive_faq

* Fixes triggering of CSRF protection in bookmarks controller spec

`get :action, format: :js` triggers CSRF protection in Rails 4.1
Replace with `xhr :get, :action, format: :js`

* Re-adds support for Minitest assertions in Cucumber steps

* Fixes Authlogic::Session::Activateion::NotActivated error in logout user step

* Fixes login step authlogic bugs

* Removes 'group_by' virtual attribute if @fandoms is empty in users controller

* Updates syntax for getting all Language ordered by short

* Fixes admin invitations feature specs

The old syntax `find(:all)` or `find(:first)` is incorrect - find now only
accepts one argument, which it expects to be the id of the object it's looking
for. This should fix the remaining spec failures in admin_invitations.feature

* Fixes syntax for scope on user

* Adds link_to_function helper

This is in place of rewriting the html/javascript everywhere to be unobtrusive:

http://guides.rubyonrails.org/working_with_javascript_in_rails.html#unobtrusive_javascript

Which is the recommended approach.

* Fixes query syntax in scope in Question model

* Fixes MySql2 syntax error by calling 'size' instead of 'count'

The bug this is addressing is described here:

rails/rails#15138

I chose to use `size` in these cases because the collections are already
loading. This by-steps the bug and isn't making another call to the database.

* Fixes problem with AR query in SeriesController

* Fix AR queries in Pseud model

* Fixes the calling of a virtual attribute on an empty array of Fandom objects in
the pseuds controller

* Fixes AR query syntax errors found in comments_and_kudos/kudos.feature

* Refactors helper method to eliminate bug

Can't call `size` on a collection that hasn't been loaded, and `count` needs to
go because of the known 4.1 but with select and count.

* Fixes AR query syntax in pseud model scope

* Fixes MySql count with select bug in challenge assignments partial

Removes whitespace

* Fixes bug where `size` was being called on `nil`

* Fixes bug with order of operations

one = 'one' && true will make one == true and return true
(one = 'one') && true will make one == 'one' and return true

* Adds rails_select_on_includes gem

This fixes a problem raised in the UsersController (and potentially elsewhere)
where Mysql was blowing up because a virtual attribute defined in a select
statement wasn't a database column.

See the issue this is discussed in: rails/rails#15185
And the Gem: https://github.com/alekseyl/rails_select_on_includes

* Commits Gemfile.lock

* Fixes `Mysql2::Error: Unknown column 'users.login'` in pseud model

Eager loading the user in two queries in the pseud model (the `by_byline` scope
and the `parse_byline` method) was causing Mysql to throw an Unknown column
error. Using a join instead fixes the problem.

* Fixes problem with includes statement

The includes statements in question referenced a has_many association that used
conditions (approved_conditions) that applied to an association of the
association. (`Work.includes(:approved_collections)` where `approved_collections`
are conditions that have collections that meet a certain criteria). By
moving the scopes that determine whether a collection is
approved/rejected/approved by user into the collectible model, the Work model
doesn't have to guess what is meant by the reference to the columns
`collection_items.attributes`.

* Removes rails_select_on_includes

It caused all other previously passing tests to start failing and didn't end up
actually solving the problem it was supposed to.

* Calls load on @fandoms in UsersController to make sure it's loaded before the
view calls `.empty?` on it

* Fixes `find :all` reference

* Fixes outdated `find :all` reference

* Fixes 'count' bug

* Fixes typo in pseud model scope

* Fixes outdated `find :all` syntax in media and tags controllers

* Calls `load` on @fandoms variable in pseuds controller to prevent `empty?` from
erroring out when it's called on @fandoms in the view

* Fixes outed `find(:first...) syntax in app/helpers/tag_helpers

* Adds Authlogic fix to tag steps that need it

* Fixes variable reference

* Fixes Authlogic problem with deleting account step

* Fixes feature failures in users caused by outdated `find :all` syntax

* Fixes works feature failures by updated outdated `find :all` syntax

* Fixes challenge_signups_controller_spec failure

* Fixes get requests with js format returning cross origin not allowed error

in comments controller spec

* Checks that expected params exist before passing them to update_attributes

* Fixes get ... format: :js line to not raise cross origin error

* Fixes outdated `find(:all)` syntax in tags controller

* Try

* Assign varible

* Try this

* And the second case

* Corgis are still lovely

* Fixes mysql syntax problem with `count` in SpamReport method

* Shortens syntax in external authors controller conditional

* Adds TODO/note about link_to_function definition

* Fixes typo in work model

* Removes duplicate line in user step definition

* Removes comment for useless gem

* Makes stylistic change - `size == 0` is better as `size.zero?`

…rks page (#2925)

* Add working tests

* Add before

* Refactor to clean up

* Listen to the hound

* Follow micro review

* quotes, continuation lines and English

* Follow review

* We need to set a large spam value

* AO3-5005 updating duplicate test in user_mailer

* AO3-5005 review comments

* New Rails.public_path behaviour http://stackoverflow.com/questions/8714645/how-to-specify-the-path-of-the-public-directory-in-a-ruby-on-rails-app

* Fix first tests

* AO3-4736 WIP Widespread code changes for Rails 3 -> Rails 4.0 upgrade.

* AO3-4736 Fixes several test failures due to Rails 4 upgrade

* AO3-4736 Adds default UTC timezone for tests to avoid timezone mismatch on Travis

* AO3-4736 Removes timezone config as well as Time call in ApiHelper

* AO3-4736 Fix timezone issue with StoryParser spec

* AO3-4736 Attempts converting api_works dates using to_date to resolve Travis issue

* AO3-4736 Uses to_date vs strftime to compare dates in story parser spec

* AO3-4736 Reverts gem version of AuthLogic

* AO3-4736 More finder updates as well as majority of failures resolved from admin feature

* AO3-4736 Fixes admin_users activation routes

* AO3-4736 Attempts reverting admin_work feature to use find_by_title for Work records

* AO3-4736 Explicitly sets Tag type in find_or_create method to avoid Rails 4.0 bug

* AO3-4736 Updates to bookmarks and series features

* AO3-4736 Updates path method to use newer patch vs put

* Updates to resolve issues with Collection features

* AO3-4736 Fixes review_all comments route

* AO3-4736 Fixes for GiftExchange and Importing features

* AO3-4736 Routing updates

* AO3-4736 Use Pacific time as Rails 4 is no longer printing the zone name PGT but -10

* AO3-4736 Autocomplete and InviteRequest updates

* AO3-4736 Fix tag_set features

* AO3-4736 Fix tag_set_nominations confirm_delete path

* AO3-4736 Resolve tag wranger feature issues

* AO3-4736 Change patch to put

* AO3-4736 Revert patch -> put change

* AO3-4736 Updates work feature tests

* AO3-4736 Remove manual updated_at assignment as its automatic

* A03-4736 Update password confirmation mismatch validation message

* AO3-4736 Tag feature updates

* AO3-4736 Fixes for other_a feature errors

* AO3-4736 Various feature fixes and adds a few bang methods to debug Travis

* Adds debugging for Travis tests

* AO3-4736 Explicitly reload the work before hitting Kudos after logging out

* AO3-4736 Use I am logged out pattern for kudos

* Check on travis

* AO3-4736 Expires cache when kudos collection changes

* AO3-4736 Revert kudos cache expiration

* AO3-4736 Touch the commentable for a Kudo to reset the cache_key properly

* AO3-4736 Resolve feature issues with invite requests and autocomplete

* AO3-4736 Resolve feature failures for other_b

* AO3-4736 Debugging MySql threadding issue in Travis

* AO3-4736 Adds step for canonical media creation

* Adds 'skip_degist: true' to view cache

`expire_fragment` will not find a cache with a digest appended, and the cache
automatically adds a digest without skip_digest

* Uses expire_fragment with skip_digest: true for kudos sweeper

Instead of dealing with an invisible digest that doesn't matter and just causes
confusion.

* Uncomments required line in step definition

* Adds `skip_digest: true` to all cache method calls in app/views

This ensures that all cache calls are bahving the same way now as they were
before the Rails 4 update.

* AO3-4736 Updates gem_security ignore list for 4.0 and add canonical adult rating step for cucumber

* Playing

* Try with precise

* AO3-4736 Resolve feature failures in Tag and Profile due to upstream changes

* AO3-4736 Update put -> patch and remove some unneeded code

* AO3-4736 Bump devise gem version

* AO3-4736 Removes deprecated code to mesh with master

* AO3-4736 Two small fixes in formatting

* AO3-4736 Revert to simpler partial rendering syntax

…2627)

* AO3-3752 Let user posting a chapter set the co-creators

* AO3-3752 Don't add co-creators by default

* AO3-3176 Have to use type rather than @chapter to avoid affecting work form

* AO3-3752 Only show co-authors when there are co-authors

* AO3-3752 Tests for co-authored chapters, co-author test step changes

* AO3-3752 Make the step for posting (draft) chapters work again

* AO3-3752 Fix spacing in chapter edit tests

* AO3-3176 Add test showing you can now edit a chapter you are not a co-author of

* AO3-3176 Add steps to prove we are editing the right chapter

* AO3-3752 Remove test for unrelated issue as this no longer fixes it

* AO3-3752 Use byline format for cocreator checkbox labels

* AO3-3752 Use double quotes in the view

* AO3-3752 Use [author_attributes][ids] rather than [coauthors] because strong parameters

We originally stuffed the coauthors params into the ids params in the controller, but we can't do that anymore with strong parameters.  We can possibly eliminate the stuffing step and use ids to begin with.

* AO3-3752 Stop concatenating author attributes

We can't concatenate params[:chapter][:author_attributes][:ids] and params[:chapter][:author_attributes] because strong parameters aren't mutable. This code was no longer working, which was a good thing because it was originally responsible for every existing co-author being added to new chapters of a work, regardless of whether you wanted that.

* AO3-3752 Fix mistake from merging with master

* AO3-35752 More tests relating to chapter coauthoring

* AO3-3752 Remove coauthor field from hidden fields and don't allow the parameter

* AO3-3752 ACTUALLY remove coauthors for chapters allowed parameters

* AO3-3176 Let any work co-author edit any chapter of the work

AO3-3176 Add editing user as a co-author to the chapter they are editing

AO3-3176 Don't override selected_pseuds in the view

AO3-3176 Consolidate the logic in the pseuds helper

AO3-3176 Better name for helper method

* AO3-3176 Don't add more unnecssary interger conversion for pseud.id, and fix a line break in a code comment

…ready on the work (#2515)

* AO3-3752 Let user posting a chapter set the co-creators

* AO3-3752 Don't add co-creators by default

* AO3-3176 Have to use type rather than @chapter to avoid affecting work form

* AO3-3752 Only show co-authors when there are co-authors

* AO3-3752 Tests for co-authored chapters, co-author test step changes

* AO3-3752 Make the step for posting (draft) chapters work again

* AO3-3752 Fix spacing in chapter edit tests

* AO3-3176 Add test showing you can now edit a chapter you are not a co-author of

* AO3-3176 Add steps to prove we are editing the right chapter

* AO3-3752 Remove test for unrelated issue as this no longer fixes it

* AO3-3752 Use byline format for cocreator checkbox labels

* AO3-3752 Use double quotes in the view

* AO3-3752 Use [author_attributes][ids] rather than [coauthors] because strong parameters

We originally stuffed the coauthors params into the ids params in the controller, but we can't do that anymore with strong parameters.  We can possibly eliminate the stuffing step and use ids to begin with.

* AO3-3752 Stop concatenating author attributes

We can't concatenate params[:chapter][:author_attributes][:ids] and params[:chapter][:author_attributes] because strong parameters aren't mutable. This code was no longer working, which was a good thing because it was originally responsible for every existing co-author being added to new chapters of a work, regardless of whether you wanted that.

* AO3-3752 Fix mistake from merging with master

* AO3-35752 More tests relating to chapter coauthoring

* AO3-3752 Remove coauthor field from hidden fields and don't allow the parameter

* AO3-3752 ACTUALLY remove coauthors for chapters allowed parameters

Remove the factory definitions in features/support, which requires:

- Keep the language factory.
- Fix the archive_faq factory (there's no content field).
- Remove common_taggings from the character factory, because
  tag wrangling feature tests assume new characters are unwrangled;
  instead, add common_taggings only for the test that needs it.
- Fix a user step to use default pseuds instead of generated ones,
  so a work edit test doesn't need to reference pseuds.

These files are unused and outdated.

* AO3-5010 Extend bookmark search feature while still using fixtures

* AO3-5010 Use factories instead of fixtures

* AO3-5010 Finish putting the fixture files back to the way they were