Permalink
Commits on Mar 30, 2017
-
-
-
* A03-4828 Implements strong params for ExternalWork * A03-4828 Adds strong params to BookmarksController as it hits the ExternalWork model that is now protected by ForbiddenAttributesProtection * A03-4828 Adds polymorphic bookmark params * A03-4828 Adds category_string to ExternalWork work_params * A03-4828 Updates external_work work_params to permit category_string as an array * AO3-4894 Implements strong parameters on Comment * AO3-4894 Cleans branch by removing changes polluted from external works * AO3-4894 Fixes issue with edited_at not getting merged in with strong params * AO3-4894 Removes unreviewed param
-
* A03-4850 Implements strong parameters and ForbiddenAttributes protection to OwnedTagSet * A03-4850 Adds tags_to_remove params to tag_set_attributes * Updates tags_to_remove params on OwnedTagSets to accept arrays * AO3-4850 Adds attributes for tag_set_associations to owned_tag_params
-
* AO3-4774 Implements strong params for ApiKey * AO3-4774 Adds logic to check for existence of api_key param before invoking strong_params
-
Commits on Mar 29, 2017
Commits on Mar 28, 2017
-
…ache (#2822) * AO3-4858 Allow sorting tag wrangling pages by taggings_count_cache * AO3-4858 Don't use tagging_count_cache in for the display on the wrangling page
Commits on Mar 27, 2017
-
* Add rspec tests for the comments controller * Add some defensive code * Fix comments_controller.rb * Missed these sorts as well
-
* Add rspec tests for the comments controller * Add some defensive code * First draft * fix conflict * Put it back * We never ever get that right * Missed this bit * Move fast moving state to redis as a burst buffer * Fix first failure * Fix second test * This feels like a better way * One last place * Cleanup tests * Move reset filter counts to be async * fix typo * Follow good suggestions from ticking instant * Test commit * Test commit * After a quick look at beta 1500 seems better than 2000
Commits on Mar 25, 2017
Commits on Mar 23, 2017
-
…2653) * AO3-4617 link directly to reset password link in login error message * AO3-4617 appeasing hound * AO3-4617 re-add problems-with-logging-in link and change links from urls to paths
-
-
-
-
-
* Add rspec tests for the comments controller * Add some defensive code * We never get this right however many times we check * Clean up
Commits on Mar 22, 2017
-
…le error (#2786) * AO3-4813 Extend tests for tag_set_associations_controller Make previously unreachable error reachable: viewing associations of a tag set that doesn't exist now redirects to the tag sets page with an error flash alert. * Remove unused factory, test associating a character with a fandom * Test different child tag types * Test adding multiple tag associations
-
…al_info (#2742)
-
-
Once the only pending test is fixed (AO3-4879), external_authors_controller will have 100% RSpec coverage. - Check invitation/external_author before/after complete_claim - Test claim instead of get_external_author_from_invitation, which is a before_filter having no view/response - Test deleting imported works - Test when the logged in user is the external author
Commits on Mar 19, 2017
-
-
* AO3-4851 Update schema and structure files * Update structure.sql Removing all the autoincrement stuff * Update structure.sql Removing last autoincrement * AO3-4851 Delete unneeded migration files * Rerunning after Devise migration * Removing auto increment nonsense again
-
* AO3-4877 Add tests and factories for tests * AO3-4877 Fix the bug * AO3-4877 Compare tag_set_ids rather than ids in owned tag set test
-
* AO3-4825 Delete prompt-restriction-tag-set-promptmeme.html Delete obsolete help file * AO3-4825 delete story-title.html obsolete help file * AO304825 delete tag-relationship-distance.html obsolete help file * AO3-4825 delete tag-relationship-reciprocal.html obsolete help file * AO3-4825 delete tag-search-type-help.html obsolete help file * AO3-4825 delete tagging-help.html obsolete help file * AO3-4825 delete work-search-bookmark-help.html obsolete help file * AO3-4825 delete bookmark-search-date-help.html obsolete help file * AO3-4825 delete challenge-defaulted-assignments.html obsolete help file * AO3-4825 delete challenge-initialize-tags.html obsolete help file * AO3-4825 delete challenge-pinch-recipient.html obsolete help file * AO3-4825 delete collection-status.html obsolete help file * AO3-4825 delete filters.html obsolete help file * AO3-4825 delete filters-info.html obsolete help file
-
* AO3-4808 - Write a test that triggers the 500 error * AO3-4808 - Make create and update paths more similar
-
#2635) * cut new chapter suggestion out of 500k character limit warning * changing the message again * pushing updated syntax changes
-
* AO3-2431 Make collection fandom count skip inherited metatags. * AO3-2431 Removed redundant self, for Hound.
-
-
* Add rspec tests for the comments controller * Add some defensive code * Fix comments_controller.rb * Slow down the deploy
Commits on Mar 17, 2017
-
* Revert "Revert "AO3-4858 We were using taggings_count in SQL queries which will not work" (#2804)" This reverts commit 199ad38. * Revert "AO3-4918 Amend deploy script to reload unicorns within maintenance window (#2801)" This reverts commit b3908ac. * Revert "AO3-4901 Divide tag set cukes into smaller files and own test group (#2789)" This reverts commit 3da0998. * Revert "AO3-4887 Challenge Assignment controller test for no_challenge (#2775)" This reverts commit 57d5d72. * Revert "AO3-4858 Queries that hit mysql have to refer to taggings_count_cache rather than taggings_count (#2799)" This reverts commit a23103b. * Revert "AO3-4869 Extend tests for external_authors controller (#2755)" This reverts commit c8953f6. * Revert "AO3-4858 Cache tag counts to speed up work posting (#2796)" This reverts commit 7f3b54a.
-
…ll not work" (#2804) * Revert "AO3-4918 Amend deploy script to reload unicorns within maintenance window (#2801)" This reverts commit b3908ac. * Revert "AO3-4901 Divide tag set cukes into smaller files and own test group (#2789)" This reverts commit 3da0998. * Revert "AO3-4887 Challenge Assignment controller test for no_challenge (#2775)" This reverts commit 57d5d72. * Revert "AO3-4858 Queries that hit mysql have to refer to taggings_count_cache rather than taggings_count (#2799)" This reverts commit a23103b.
-