/otwarchive

AO3-5014 Use the same factories for unit and feature tests #2913

Merged
merged 1 commit into from May 8, 2017

Conversation

Reviewers

@sarken sarken

Assignees
No one assigned
Labels
Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
3 participants
@redsummernight @zz9pzza @sarken
@redsummernight
Contributor

redsummernight commented May 7, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5014

Purpose

Remove the factory definitions in features/support, which requires:

  • Keep the language factory.
  • Fix the archive_faq factory (there's no content field).
  • Remove common_taggings from the character factory, because tag wrangling feature tests assume new characters are unwrangled; instead, add common_taggings only for the test that needs it.
  • Fix a user step to use default pseuds instead of generated ones, so a work edit test doesn't need to reference pseuds.

Testing

Automated.
@redsummernight redsummernight AO3-5014 Use the same factories for unit and feature tests 
Remove the factory definitions in features/support, which requires:

- Keep the language factory.
- Fix the archive_faq factory (there's no content field).
- Remove common_taggings from the character factory, because
  tag wrangling feature tests assume new characters are unwrangled;
  instead, add common_taggings only for the test that needs it.
- Fix a user step to use default pseuds instead of generated ones,
  so a work edit test doesn't need to reference pseuds.

All checks have passed

3 successful checks
Scrutinizer — No new issues
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
433dfe3
@zz9pzza
Contributor

zz9pzza commented May 7, 2017

Looks reasonable to me, but needs more eyes.

sarken added the Awaiting review label May 7, 2017

@sarken
Owner

sarken commented May 8, 2017

Looks good to me too!
@sarken

sarken approved these changes May 8, 2017
View changes

@zz9pzza zz9pzza added Reviewed: Ready to Merge and removed Awaiting review labels May 8, 2017

@zz9pzza zz9pzza merged commit ef1fc80 into otwcode:master May 8, 2017
3 checks passed

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

redsummernight deleted the redsummernight:AO3-5014-factories-united branch May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment