/otwarchive

AO3-5010 Extend bookmark search feature and use factories #2907

Merged
merged 3 commits into from May 7, 2017

Conversation

Reviewers

@houndci-bot houndci-bot

@zz9pzza zz9pzza

Assignees
No one assigned
Labels
Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
3 participants
@sarken @zz9pzza @houndci-bot
@sarken
Owner

sarken commented May 6, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5010

Purpose

This extends the bookmark search feature. It also switches from using fixtures to factories, although that adds 2 or more minutes to the test time on my machine.

Testing

Should pass Travis and Codeship. No manual testing required.

sarken added some commits May 6, 2017

@sarken sarken AO3-5010 Extend bookmark search feature while still using fixtures

Some checks were not successful

1 errored, 1 failing, and 1 successful checks
Scrutinizer — Canceled
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
hound — No violations found. Woof!
6af8632
@sarken sarken AO3-5010 Use factories instead of fixtures

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
Scrutinizer — 1 new issues
Details
hound — 1 violation found.
2a9860b

sarken added the Awaiting review label May 6, 2017

features/step_definitions/bookmark_steps.rb
@@ -22,6 +22,56 @@
Bookmark.tire.index.refresh
end
+Given /^I have bookmarks to search$/ do
@houndci-bot

houndci-bot May 6, 2017

Block has too many lines. [31/25]

sarken referenced this pull request May 6, 2017

Closed

AO3-3583 Type field on bookmark search loses info on editing search #2908

@sarken sarken AO3-5010 Finish putting the fixture files back to the way they were

All checks have passed

3 successful checks
Scrutinizer — 3 new issues
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — 1 violation found.
997ebf4

sarken referenced this pull request May 7, 2017

Open

AO3-3583 Type field on bookmark search loses info on editing search #2912

@zz9pzza

zz9pzza approved these changes May 7, 2017
View changes

@zz9pzza zz9pzza added Reviewed: Ready to Merge and removed Awaiting review labels May 7, 2017

@zz9pzza zz9pzza merged commit 44676ae into otwcode:master May 7, 2017
3 checks passed

3 checks passed

Scrutinizer 3 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound 1 violation found.

sarken deleted the sarken:AO3-5010 branch Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment