Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
jquery/jquery
AvinashMudunuri/jquery
ChineseDron/jquery
Craga89/jquery
CuoBian/jQuery
DannaB67/jquery
Dannyzn/jquery
DouglasMeyer/jquery
Holek/jquery
IndiesServices/jquery
JangoSteve/jquery
JungMinu/jquery
JurekRaben/jquery
KrisTemmerman/jquery
MartinMa/jquery
MoonScript/jquery
NV/jquery
NandoKstroNet/jquery
STRd6/jquery
ScxFiction/jquery
SlexAxton/jquery
VeerababuK/jquery
WilliamHSS/jquery
aakoch/jquery
aburo/jquery
adamdbradley/jquery
adardesign/jquery
addyosmani/jquery-1
agafex2/jquery
ahmamin/jquery
airportyh/jquery
ajpiano/jquery
alanburke/jquery
alisonperez/jquery
ambastos/jquery
amokila/jquery
anthonyernst/jquery
argiope/jquery
arschmitz/jquery
aydincandan/jquery
azatoth/jquery
baby2011/jquery
balupton/jquery
barkermn01/jquery
bartb/jquery
batiste/jquery
beverloo/jquery
brainlock/jquery
brandonaaron/jquery
bskahan/jquery
bsterne/jquery
cburgdorf/jquery
chancharles/jquery
chokcoco/jquery
christophermoura/jquery
clarke78/jquery
cortextual/jquery
cowboy/jquery
cr0ss/jquery
cricket/jquery
dailiqi/jquery
dalosko/jquery
darrellsilver/jquery
darwin/jquery
dbpeer/jquery
dcneiner/jquery
deadlyicon/jquery
dieseltravis/jquery
dimka/jquery
diracdeltas/jquery
djanowski/jquery
dmaffioletti/jquery
dmethvin/jquery
doofius/jquery
dsc/jquery
dstaudigel/jquery-xpcom
dtjm/jquery
dts/jquery-xpcom
dz/jquery
eivindingebrigtsen/jquery
eliotsolomon/jquery
eric-brechemier/jquery
fat/jquery
fitzgen/jquery
foamdino/jquery
fparent/jquery
fracmak/jquery
gibson042/jquery
gitfq/jquery
gyongyeee/jquery
halvardos/unamerican-jquery
haolic/jquery
iammikewilson/jquery
iamnoah/jquery
igorw-forks/jquery
ihab/jquery
iliakan/jquery
ilyakharlamov/jquery-xul
irae/jquery
ishermandom/jquery
jablko/jquery
jameserie/jquery
jclain/jquery
jedzhu/jquery
jimmyjames/jquery
jitter/jquery
jmar777/jquery
jollytoad/jquery
joshbuddy/jquery
joshvarner/jquery
jratlif46/jquery
jrburke/jquery
jryans/jquery
jtaby/jquery
jupiterjs/jquery
justinbmeyer/jquery
jwalsh/jquery
k9ordon/jquery
karbassi/jquery
keichee/jquery
kiddphunk/jquery
kirbysayshi/jquery-jqd
kpozin/jquery-nodom
krunkosaurus/jquery
kyanny/jquery
lambder/jquery
lihuiyang/jquery
lixiaopeng/jquery
ljharb/jquery
lkrause/jquery
loquocphong/jquery
louisremi/jquery
marcelinhov2/jquery
markelog/jquery
mazenslist/jquery
megawolt/jquery
metadings/jquery
mhiku/jquery
mikesherov/jquery
miketaylr/jquery
mislav/jquery
mmonteleone/jquery
mojombo/jquery
mrdiehl/jquery
nikhilgk/jquery
niyazpk/jquery
nje/jquery
paddymul/jquery
padolsey/jquery
paulirish/jquery
peterbraden/jquery
petersendidit/jquery
polotek/jquery
quirkey/jquery
ravexx/jquery
razorpay/rQuery
rdworth/jquery
remy/jquery
rherb/jquery
rjgotten/jquery
rkatic/jquery
rmurphey/jquery
robinhood-zz/jquery
rpg-scriptum/jquery
rwaldron/jquery
ryanflorence/jquery
ryanseddon/jquery
salty-horse/jquery
satyr/jquery
scalvert/jquery
scottgonzalez/jquery
scottjehl/jquery
shrage/jquery
sikachu/jquery
sizers/jquery
skoon/jquery
snippt/jquery
songjina/jquery
spocke/jquery
ssarts/jquery
strg/jquery
technoweenie/jquery
temp01/jquery
tenaciouskay7/jquery
tester2000/jquery
therabidbanana/jquery
thetoolman/jquery
timmywil/jquery
trojanspike/jquery
typLAB/jquery
unlox775/jquery
utkarshkukreti/jquery
vectart/jquery
virtix/jquery
xavi-/jquery
xiaodanli/jquery
yaychris/jquery
yunhyosang/jquery
yuni/jquery
zpao/jquery
Nothing to show
Choose a base branch
...
Choose a Head Repository
jquery/jquery
AvinashMudunuri/jquery
ChineseDron/jquery
Craga89/jquery
CuoBian/jQuery
DannaB67/jquery
Dannyzn/jquery
DouglasMeyer/jquery
Holek/jquery
IndiesServices/jquery
JangoSteve/jquery
JungMinu/jquery
JurekRaben/jquery
KrisTemmerman/jquery
MartinMa/jquery
MoonScript/jquery
NV/jquery
NandoKstroNet/jquery
STRd6/jquery
ScxFiction/jquery
SlexAxton/jquery
VeerababuK/jquery
WilliamHSS/jquery
aakoch/jquery
aburo/jquery
adamdbradley/jquery
adardesign/jquery
addyosmani/jquery-1
agafex2/jquery
ahmamin/jquery
airportyh/jquery
ajpiano/jquery
alanburke/jquery
alisonperez/jquery
ambastos/jquery
amokila/jquery
anthonyernst/jquery
argiope/jquery
arschmitz/jquery
aydincandan/jquery
azatoth/jquery
baby2011/jquery
balupton/jquery
barkermn01/jquery
bartb/jquery
batiste/jquery
beverloo/jquery
brainlock/jquery
brandonaaron/jquery
bskahan/jquery
bsterne/jquery
cburgdorf/jquery
chancharles/jquery
chokcoco/jquery
christophermoura/jquery
clarke78/jquery
cortextual/jquery
cowboy/jquery
cr0ss/jquery
cricket/jquery
dailiqi/jquery
dalosko/jquery
darrellsilver/jquery
darwin/jquery
dbpeer/jquery
dcneiner/jquery
deadlyicon/jquery
dieseltravis/jquery
dimka/jquery
diracdeltas/jquery
djanowski/jquery
dmaffioletti/jquery
dmethvin/jquery
doofius/jquery
dsc/jquery
dstaudigel/jquery-xpcom
dtjm/jquery
dts/jquery-xpcom
dz/jquery
eivindingebrigtsen/jquery
eliotsolomon/jquery
eric-brechemier/jquery
fat/jquery
fitzgen/jquery
foamdino/jquery
fparent/jquery
fracmak/jquery
gibson042/jquery
gitfq/jquery
gyongyeee/jquery
halvardos/unamerican-jquery
haolic/jquery
iammikewilson/jquery
iamnoah/jquery
igorw-forks/jquery
ihab/jquery
iliakan/jquery
ilyakharlamov/jquery-xul
irae/jquery
ishermandom/jquery
jablko/jquery
jameserie/jquery
jclain/jquery
jedzhu/jquery
jimmyjames/jquery
jitter/jquery
jmar777/jquery
jollytoad/jquery
joshbuddy/jquery
joshvarner/jquery
jratlif46/jquery
jrburke/jquery
jryans/jquery
jtaby/jquery
jupiterjs/jquery
justinbmeyer/jquery
jwalsh/jquery
k9ordon/jquery
karbassi/jquery
keichee/jquery
kiddphunk/jquery
kirbysayshi/jquery-jqd
kpozin/jquery-nodom
krunkosaurus/jquery
kyanny/jquery
lambder/jquery
lihuiyang/jquery
lixiaopeng/jquery
ljharb/jquery
lkrause/jquery
loquocphong/jquery
louisremi/jquery
marcelinhov2/jquery
markelog/jquery
mazenslist/jquery
megawolt/jquery
metadings/jquery
mhiku/jquery
mikesherov/jquery
miketaylr/jquery
mislav/jquery
mmonteleone/jquery
mojombo/jquery
mrdiehl/jquery
nikhilgk/jquery
niyazpk/jquery
nje/jquery
paddymul/jquery
padolsey/jquery
paulirish/jquery
peterbraden/jquery
petersendidit/jquery
polotek/jquery
quirkey/jquery
ravexx/jquery
razorpay/rQuery
rdworth/jquery
remy/jquery
rherb/jquery
rjgotten/jquery
rkatic/jquery
rmurphey/jquery
robinhood-zz/jquery
rpg-scriptum/jquery
rwaldron/jquery
ryanflorence/jquery
ryanseddon/jquery
salty-horse/jquery
satyr/jquery
scalvert/jquery
scottgonzalez/jquery
scottjehl/jquery
shrage/jquery
sikachu/jquery
sizers/jquery
skoon/jquery
snippt/jquery
songjina/jquery
spocke/jquery
ssarts/jquery
strg/jquery
technoweenie/jquery
temp01/jquery
tenaciouskay7/jquery
tester2000/jquery
therabidbanana/jquery
thetoolman/jquery
timmywil/jquery
trojanspike/jquery
typLAB/jquery
unlox775/jquery
utkarshkukreti/jquery
vectart/jquery
virtix/jquery
xavi-/jquery
xiaodanli/jquery
yaychris/jquery
yunhyosang/jquery
yuni/jquery
zpao/jquery
Nothing to show
Choose a head branch
Commits on Sep 22, 2016
Commits on Oct 26, 2016
Commits on Oct 31, 2016
Docs: Remove supported jQuery versions from ISSUE_TEMPLATE.md
We no longer support jQuery 1.x/2.x and mentioning 3.x would just mean the text
gets out of date once we release jQuery 4. We only really support the latest
jQuery version so let's make that clear.

Closes gh-3372
Build: Stop testing on Node.js 0.10
Node.js 0.10 loses upstream support today (see https://github.com/nodejs/LTS/)
so let's stop testing against it as well.
Commits on Nov 30, 2016
Commits on Dec 05, 2016
Build: Make the @CODE-replacing regex more robust
The code replacing @CODE in wrapper.js was written so that it expected
both the code and the next line to start in the first column. This commit
adjusts the regex so to get rid of that assumption and to work properly
regardless of number of lines with comments after this block.

While this is technically not necessary for our code, contributors sometimes
re-format the wrapper file in their pull requests and the error
messages they get don't tell them what's the real problem with their code.

Closes gh-3429
Commits on Dec 13, 2016
Commits on Dec 16, 2016
Commits on Dec 19, 2016
Build: ESLint setup improvements
1. Use the short name of the preset in the config.
2. Run ESLint first on non-minified files.
3. Explicitly specify environments in every config file (those settings cascade
which means we've been assuming a Node.js environment where we shouldn't have).
Build: Drop jscs.json from .npmignore
The file doesn't exist anymore.
Build: Add most of the dist folder to .eslintignore
This way `eslint .` run from the terminal will work regardless of ignored
files present in the repository.

Closes gh-3385
Build: Use valid ecmaVersion
Fixes Node smoke tests

Ref gh-3385
Closes gh-3460
Commits on Dec 29, 2016
Commits on Dec 30, 2016
Build: Drop support for building on Node.js 0.12
Node.js 0.12 is no longer supported by upstream. So far we had to keep
a workaround that would skip running ESLint there (or even load its task)
as it no longer supports Node.js <4; the same applied to Node smoke tests
as jsdom has also dropped support for those old Node versions. Those
workarounds have been removed now.

Ref 030191a
Closes gh-3478
Commits on Jan 05, 2017
Commits on Jan 09, 2017
Build: fix markerPattern and ticketPattern regexes in package.json
Commit messages used to fail the style check if they contained a word
starting with "ref", like reformat or reference, in their message body.

Close gh-3437
Ref jzaefferer/commitplease#91
Tests: Update the loader so test pages always get jQuery
Pages used for iframe tests will now successfully load jQuery, even when
opened directly in the browser.

Closes gh-3489
Manipulation: Restrict the tbody search to child nodes
For performance, use a querySelectorAll path instead of Javascript iteration.
http://codepen.io/anon/pen/vywJjx?editors=1010

Fixes gh-3439
Closes gh-3463
Commits on Jan 16, 2017
Effects: Resolve issues revealed by recent Callbacks fix
Notify full progress before resolving empty animations
Register animation callbacks before their ticker
Remove the right timer when immediately-done animations spawn more

Ref 9d822bc
Fixes gh-3502
Fixes gh-3503
Closes gh-3496
Commits on Jan 19, 2017
Commits on Jan 29, 2017
Commits on Feb 13, 2017
Commits on Mar 01, 2017
Commits on Mar 06, 2017
Effects: stabilize rAF logic & align timeout logic with it
rAF logic was introduced almost three years ago relative to this commit,
as a primary method for scheduling animation (see gh-1578 pull).

With it there was two substantial changes - one was explicitly mentioned
and the other was not.

First, if browser window was hidden aka `document.hidden === true`
it would immediately execute all scheduled animation without waiting
for time pass i.e. tick time become `0` instead of 13 ms of a default value.

Which created possibility for circular executions in case if `complete`
method executed the same animation (see gh-3434 issue).

And the second one - since then there was two ways of scheduling animation:
with `setInterval` and `requestAnimationFrame`, but there was a
difference in their execution.

In case of `setInterval` it waited default `jQuery.fx.interval` value before
actually starting the new tick, not counting the first step which wasn't
set to be executed through tick method (aka `jQuery.fx.tick`).

Whereas `requestAnimationFrame` first scheduled the call and executed
the `step` method right after that, counting the first call of
`jQuery.fx.timer`, `tick` was happening twice in one frame.

But since tests explicitly disabled rAF method i.e.
`requestAnimationFrame = null` and checking only `setInterval` logic,
since it's impossible to do it otherwise - we missed that change.

Faulty logic also was presented with `cancelAnimationFrame`, which couldn't
clear any timers since `raf` scheduler didn't define new `timerId` value.

Because that change was so subtle, apparently no user noticed it proving
that both `cancelAnimationFrame` and `clearInterval` code paths are redundant.

Since `cancelAnimationFrame` didn't work properly and rAF is and was a primary
used code path, plus the same approach is used in other popular animation libs.

Therefore those code paths were removed.

These changes also replace two different functions which schedule the animation
with one, which checks what type of logic should be used and executes it
appropriatley, but for secondary path it now uses `setTimeout` making it more
consistent with rAF path.

Since ticks are happening globally we also don't require to listen
`visibilitychange` event.

It also changes the way how first call is scheduled so execution of
animation will not happen twice in one frame.

No new tests were not introduced, since now `setTimeout` logic should be
equivalent to the rAF one, but one test was changed since now we actually
execute animation at the first tick.

Fixes gh-3434
Closes gh-3559
Build: fix tests in AMD mode
- nodeName was included at the wrong spot in dependency lists
Commits on Mar 07, 2017
Commits on Mar 13, 2017
CSS: remove dead code in getWidthOrHeight
- getCSS already falls back to inline styles

Ref gh-3561
Commits on Mar 15, 2017
Commits on Mar 16, 2017
Showing with 19,098 additions and 330 deletions.
  1. +2 −0 .eslintignore
  2. +31 −0 .eslintrc-browser.json
  3. +13 −0 .eslintrc-node.json
  4. +2 −4 .eslintrc.json
  5. +2 −2 .github/ISSUE_TEMPLATE.md
  6. +0 −1 .npmignore
  7. +1 −2 .travis.yml
  8. +6 −0 AUTHORS.txt
  9. +2 −2 CONTRIBUTING.md
  10. +19 −27 Gruntfile.js
  11. +1 −1 LICENSE.txt
  12. +5 −5 build/release.js
  13. +1 −1 build/release/cdn.js
  14. +5 −1 build/tasks/build.js
  15. +4 −1 dist/.eslintrc.json
  16. +10,244 −0 dist/jquery.js
  17. +4 −0 dist/jquery.min.js
  18. +1 −0 dist/jquery.min.map
  19. +8,151 −0 dist/jquery.slim.js
  20. +4 −0 dist/jquery.slim.min.js
  21. +1 −0 dist/jquery.slim.min.map
  22. +5 −5 package.json
  23. +3 −16 src/.eslintrc.json
  24. +3 −2 src/attributes/attr.js
  25. +6 −4 src/attributes/val.js
  26. +1 −1 src/callbacks.js
  27. +3 −9 src/core.js
  28. +1 −0 src/core/init.js
  29. +13 −0 src/core/nodeName.js
  30. +0 −9 src/core/ready-no-deferred.js
  31. +0 −9 src/core/ready.js
  32. +45 −39 src/css.js
  33. +3 −2 src/css/curCSS.js
  34. +1 −1 src/data/Data.js
  35. +8 −6 src/deferred.js
  36. +12 −2 src/deprecated.js
  37. +38 −32 src/effects.js
  38. +9 −4 src/event.js
  39. +9 −7 src/manipulation.js
  40. +4 −3 src/manipulation/getAll.js
  41. +21 −24 src/offset.js
  42. +1 −1 src/queue.js
  43. +4 −4 src/serialize.js
  44. +15 −2 src/traversing.js
  45. 0 src/{manipulation → }/var/rcheckableType.js
  46. +1 −1 src/wrapper.js
  47. +12 −8 test/.eslintrc.json
  48. +1 −1 test/data/testinit.js
  49. +1 −1 test/data/testrunner.js
  50. +34 −33 test/jquery.js
  51. +9 −3 test/node_smoke_tests/.eslintrc.json
  52. +3 −2 test/promises_aplus_adapters/.eslintrc.json
  53. +21 −0 test/unit/callbacks.js
  54. +20 −11 test/unit/core.js
  55. +77 −0 test/unit/css.js
  56. +2 −2 test/unit/deferred.js
  57. +54 −0 test/unit/deprecated.js
  58. +11 −0 test/unit/dimensions.js
  59. +11 −17 test/unit/effects.js
  60. +26 −11 test/unit/event.js
  61. +28 −8 test/unit/manipulation.js
  62. +30 −2 test/unit/offset.js
  63. +1 −1 test/unit/queue.js
  64. +52 −0 test/unit/traversing.js
View
@@ -1,6 +1,8 @@
external
node_modules
*.min.js
+dist/**
+!dist/jquery.js
test/data/jquery-1.9.1.js
test/data/badcall.js
test/data/badjson.js
View
@@ -0,0 +1,31 @@
+{
+ "root": true,
+
+ "extends": "jquery",
+
+ // Support: IE <=9 only, Android <=4.0 only
+ // The above browsers are failing a lot of tests in the ES5
+ // test suite at http://test262.ecmascript.org.
+ "parserOptions": {
+ "ecmaVersion": 3
+ },
+
+ // The browser env is not enabled on purpose so that code takes
+ // all browser-only globals from window instead of assuming
+ // they're available as globals. This makes it possible to use
+ // jQuery with tools like jsdom which provide a custom window
+ // implementation.
+ "env": {},
+
+ "globals": {
+ "window": true,
+ "jQuery": true,
+ "define": true,
+ "module": true,
+ "noGlobal": true
+ },
+
+ "rules": {
+ "strict": ["error", "function"]
+ }
+}
View
@@ -0,0 +1,13 @@
+{
+ "root": true,
+
+ "extends": "jquery",
+
+ "parserOptions": {
+ "ecmaVersion": 5
+ },
+
+ "env": {
+ "node": true
+ }
+}
View
@@ -1,7 +1,5 @@
{
- "extends": "eslint-config-jquery",
"root": true,
- "env": {
- "node": true
- }
+
+ "extends": "./.eslintrc-node.json"
}
@@ -4,10 +4,10 @@ Feature Requests:
Most features should start as plugins outside of jQuery.
Bug Reports:
- Note that we only can fix bugs in the latest (1.x, 2.x, 3.x) versions of jQuery.
+ Note that we only can fix bugs in the latest version of jQuery.
Briefly describe the issue you've encountered
* What do you expect to happen?
- * What acually happens?
+ * What actually happens?
* Which browsers are affected?
Provide a *minimal* test case, see https://webkit.org/test-case-reduction/
Use the latest shipping version of jQuery in your test case!
View
@@ -3,7 +3,6 @@
/.editorconfig
/.gitattributes
-/.jscs.json
/.mailmap
/.travis.yml
View
@@ -1,7 +1,6 @@
language: node_js
sudo: false
node_js:
-- "0.10"
-- "0.12"
- "4"
- "6"
+- "7"
View
@@ -293,3 +293,9 @@ Damian Senn <[email protected]>
Ralin Chimev <[email protected]>
Felipe Sateler <[email protected]>
Christophe Tafani-Dereeper <[email protected]>
+Manoj Kumar <[email protected]>
+David Broder-Rodgers <[email protected]>
+Alex Louden <[email protected]>
+Alex Padilla <[email protected]>
+南漂一卒 <[email protected]>
+karan-96 <[email protected]>
View
@@ -8,15 +8,15 @@
Note: This is the code development repository for *jQuery Core* only. Before opening an issue or making a pull request, be sure you're in the right place.
* jQuery plugin issues should be reported to the author of the plugin.
* jQuery Core API documentation issues can be filed [at the API repo](https://github.com/jquery/api.jquery.com/issues).
-* Bugs or suggestions for other jQuery Foundation projects should be filed in [their respective repos](https://github.com/jquery/).
+* Bugs or suggestions for other jQuery organization projects should be filed in [their respective repos](https://github.com/jquery/).
## Getting Involved
[API design principles](https://github.com/jquery/jquery/wiki/API-design-guidelines)
We're always looking for help [identifying bugs](#how-to-report-bugs), writing and reducing test cases, and improving documentation. And although new features are rare, anything passing our [guidelines](https://github.com/jquery/jquery/wiki/Adding-new-features) will be considered.
-More information on how to contribute to this and other jQuery Foundation projects is at [contribute.jquery.org](https://contribute.jquery.org), including a short guide with tips, tricks, and ideas on [getting started with open source](https://contribute.jquery.org/open-source/). Please review our [commit & pull request guide](https://contribute.jquery.org/commits-and-pull-requests/) and [style guides](https://contribute.jquery.org/style-guide/) for instructions on how to maintain a fork and submit patches. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](https://contribute.jquery.org/cla/).
+More information on how to contribute to this and other jQuery organization projects is at [contribute.jquery.org](https://contribute.jquery.org), including a short guide with tips, tricks, and ideas on [getting started with open source](https://contribute.jquery.org/open-source/). Please review our [commit & pull request guide](https://contribute.jquery.org/commits-and-pull-requests/) and [style guides](https://contribute.jquery.org/style-guide/) for instructions on how to maintain a fork and submit patches. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](https://contribute.jquery.org/cla/).
## Questions and Discussion
View
@@ -13,15 +13,7 @@ module.exports = function( grunt ) {
}
var fs = require( "fs" ),
- gzip = require( "gzip-js" ),
- oldNode = /^v0\./.test( process.version );
-
- // Support: Node.js <4
- // Skip running tasks that dropped support for Node.js 0.10 & 0.12
- // in those Node versions.
- function runIfNewNode( task ) {
- return oldNode ? "print_old_node_message:" + task : task;
- }
+ gzip = require( "gzip-js" );
if ( !grunt.option( "filename" ) ) {
grunt.option( "filename", "jquery.js" );
@@ -175,7 +167,7 @@ module.exports = function( grunt ) {
"ascii_only": true
},
banner: "/*! jQuery v<%= pkg.version %> | " +
- "(c) jQuery Foundation | jquery.org/license */",
+ "(c) JS Foundation and other contributors | jquery.org/license */",
compress: {
"hoist_funs": false,
loops: false,
@@ -187,32 +179,32 @@ module.exports = function( grunt ) {
} );
// Load grunt tasks from NPM packages
- // Support: Node.js <4
- // Don't load the eslint task in old Node.js, it won't parse.
- require( "load-grunt-tasks" )( grunt, {
- pattern: oldNode ? [ "grunt-*", "!grunt-eslint" ] : [ "grunt-*" ]
- } );
+ require( "load-grunt-tasks" )( grunt );
// Integrate jQuery specific tasks
grunt.loadTasks( "build/tasks" );
- grunt.registerTask( "print_old_node_message", function() {
- var task = [].slice.call( arguments ).join( ":" );
- grunt.log.writeln( "Old Node.js detected, running the task \"" + task + "\" skipped..." );
- } );
-
grunt.registerTask( "lint", [
"jsonlint",
- runIfNewNode( "eslint" )
+
+ // Running the full eslint task without breaking it down to targets
+ // would run the dist target first which would point to errors in the built
+ // file, making it harder to fix them. We want to check the built file only
+ // if we already know the source files pass the linter.
+ "eslint:dev",
+ "eslint:dist"
] );
grunt.registerTask( "lint:newer", [
"newer:jsonlint",
- runIfNewNode( "newer:eslint" )
+
+ // Don't replace it with just the task; see the above comment.
+ "newer:eslint:dev",
+ "newer:eslint:dist"
] );
- grunt.registerTask( "test:fast", runIfNewNode( "node_smoke_tests" ) );
- grunt.registerTask( "test:slow", runIfNewNode( "promises_aplus_tests" ) );
+ grunt.registerTask( "test:fast", "node_smoke_tests" );
+ grunt.registerTask( "test:slow", "promises_aplus_tests" );
grunt.registerTask( "test", [
"test:fast",
@@ -221,20 +213,20 @@ module.exports = function( grunt ) {
grunt.registerTask( "dev", [
"build:*:*",
- runIfNewNode( "newer:eslint:dev" ),
+ "newer:eslint:dev",
"newer:uglify",
"remove_map_comment",
"dist:*",
"compare_size"
] );
grunt.registerTask( "default", [
- runIfNewNode( "eslint:dev" ),
+ "eslint:dev",
"build:*:*",
"uglify",
"remove_map_comment",
"dist:*",
- runIfNewNode( "eslint:dist" ),
+ "eslint:dist",
"test:fast",
"compare_size"
] );
View
@@ -1,4 +1,4 @@
-Copyright jQuery Foundation and other contributors, https://jquery.org/
+Copyright JS Foundation and other contributors, https://js.foundation/
This software consists of voluntary contributions made by many
individuals. For exact contribution history, see the revision history
View
@@ -49,7 +49,7 @@ module.exports = function( Release ) {
generateArtifacts: function( callback ) {
Release.exec( "grunt", "Grunt command failed" );
Release.exec(
- "grunt custom:-ajax,-effects,-deprecated --filename=jquery.slim.js && " +
+ "grunt custom:-ajax,-effects --filename=jquery.slim.js && " +
"grunt remove_map_comment --filename=jquery.slim.js",
"Grunt custom failed"
);
@@ -83,8 +83,8 @@ module.exports = function( Release ) {
};
module.exports.dependencies = [
- "archiver@0.14.2",
- "[email protected].0",
- "npm@2.3.0",
- "[email protected].1"
+ "archiver@1.3.0",
+ "[email protected].7",
+ "npm@4.4.1",
+ "[email protected].3"
];
View
@@ -87,7 +87,7 @@ function makeArchives( Release, callback ) {
item.replace( rver, Release.newVersion );
} );
- sum = Release.exec( "md5sum " + files.join( " " ), "Error retrieving md5sum" );
+ sum = Release.exec( "md5 -r " + files.join( " " ), "Error retrieving md5sum" );
fs.writeFileSync( md5file, sum );
files.push( md5file );
View
@@ -17,7 +17,11 @@ module.exports = function( grunt ) {
read = function( fileName ) {
return grunt.file.read( srcFolder + fileName );
},
- wrapper = read( "wrapper.js" ).split( /\/\/ \@CODE\n\/\/[^\n]+/ ),
+
+ // Catch `// @CODE` and subsequent comment lines event if they don't start
+ // in the first column.
+ wrapper = read( "wrapper.js" ).split( /[\x20\t]*\/\/ @CODE\n(?:[\x20\t]*\/\/[^\n]+\n)*/ ),
+
config = {
baseUrl: "src",
name: "jquery",
View
@@ -1,5 +1,8 @@
{
- "extends": "../src/.eslintrc.json",
+ "root": true,
+
+ "extends": "../.eslintrc-browser.json",
+
"rules": {
// That is okay for the built version
"no-multiple-empty-lines": "off",
Oops, something went wrong.

Showing you all comments on commits in this comparison.

Member

mgol commented on bf3a43e Feb 28, 2017

What do you mean? If you found a bug please report an issue with steps to reproduce.

Member

mgol commented on bf3a43e Mar 1, 2017

I don't really understand what you're saying. What exactly would be strange? The only thing that matters (correctness-wise) is what jQuery method for which parameter returns which value - and how it differs from what's expected. But if nothing differs then there's no problem...

Member

markelog commented on ac9e301 Mar 6, 2017

This breaks amd build, I'm suggesting either revert or immediate fix

Owner

timmywil commented on ac9e301 Mar 6, 2017

Fixed.

Owner

timmywil commented on ac9e301 Mar 6, 2017

@mgol also noticed that nodeName was accidentally put on jQuery.fn instead of jQuery. See #3560.

Member

Krinkle commented on 0f52adc Mar 17, 2017

Owner

timmywil commented on 0f52adc Mar 17, 2017

Thanks! I'll look into that.

Owner

dmethvin commented on ac9e301 Jul 17, 2017

This is in the wrong position, it should follow DomEval above.

Owner

dmethvin commented on ac9e301 Jul 17, 2017

This is in the wrong position, it should follow support above.

Owner

dmethvin commented on ac9e301 Jul 17, 2017

This is in the wrong position, it should follow rneedsContext above.

Member

mgol commented on ac9e301 Jul 17, 2017

This is an old commit, hasn't this all been fixed already?

Owner

dmethvin commented on ac9e301 Jul 17, 2017

Yep, i got lost in the commit history while tracking down a problem.