Comparing changes
Open a pull request
- +2 −0 .eslintignore
- +31 −0 .eslintrc-browser.json
- +13 −0 .eslintrc-node.json
- +2 −4 .eslintrc.json
- +2 −2 .github/ISSUE_TEMPLATE.md
- +0 −1 .npmignore
- +1 −2 .travis.yml
- +6 −0 AUTHORS.txt
- +2 −2 CONTRIBUTING.md
- +19 −27 Gruntfile.js
- +1 −1 LICENSE.txt
- +5 −5 build/release.js
- +1 −1 build/release/cdn.js
- +5 −1 build/tasks/build.js
- +4 −1 dist/.eslintrc.json
- +10,244 −0 dist/jquery.js
- +4 −0 dist/jquery.min.js
- +1 −0 dist/jquery.min.map
- +8,151 −0 dist/jquery.slim.js
- +4 −0 dist/jquery.slim.min.js
- +1 −0 dist/jquery.slim.min.map
- +5 −5 package.json
- +3 −16 src/.eslintrc.json
- +3 −2 src/attributes/attr.js
- +6 −4 src/attributes/val.js
- +1 −1 src/callbacks.js
- +3 −9 src/core.js
- +1 −0 src/core/init.js
- +13 −0 src/core/nodeName.js
- +0 −9 src/core/ready-no-deferred.js
- +0 −9 src/core/ready.js
- +45 −39 src/css.js
- +3 −2 src/css/curCSS.js
- +1 −1 src/data/Data.js
- +8 −6 src/deferred.js
- +12 −2 src/deprecated.js
- +38 −32 src/effects.js
- +9 −4 src/event.js
- +9 −7 src/manipulation.js
- +4 −3 src/manipulation/getAll.js
- +21 −24 src/offset.js
- +1 −1 src/queue.js
- +4 −4 src/serialize.js
- +15 −2 src/traversing.js
- 0 src/{manipulation → }/var/rcheckableType.js
- +1 −1 src/wrapper.js
- +12 −8 test/.eslintrc.json
- +1 −1 test/data/testinit.js
- +1 −1 test/data/testrunner.js
- +34 −33 test/jquery.js
- +9 −3 test/node_smoke_tests/.eslintrc.json
- +3 −2 test/promises_aplus_adapters/.eslintrc.json
- +21 −0 test/unit/callbacks.js
- +20 −11 test/unit/core.js
- +77 −0 test/unit/css.js
- +2 −2 test/unit/deferred.js
- +54 −0 test/unit/deprecated.js
- +11 −0 test/unit/dimensions.js
- +11 −17 test/unit/effects.js
- +26 −11 test/unit/event.js
- +28 −8 test/unit/manipulation.js
- +30 −2 test/unit/offset.js
- +1 −1 test/unit/queue.js
- +52 −0 test/unit/traversing.js
| @@ -1,6 +1,8 @@ | ||
| external | ||
| node_modules | ||
| *.min.js | ||
| +dist/** | ||
| +!dist/jquery.js | ||
| test/data/jquery-1.9.1.js | ||
| test/data/badcall.js | ||
| test/data/badjson.js | ||
| @@ -0,0 +1,31 @@ | ||
| +{ | ||
| + "root": true, | ||
| + | ||
| + "extends": "jquery", | ||
| + | ||
| + // Support: IE <=9 only, Android <=4.0 only | ||
| + // The above browsers are failing a lot of tests in the ES5 | ||
| + // test suite at http://test262.ecmascript.org. | ||
| + "parserOptions": { | ||
| + "ecmaVersion": 3 | ||
| + }, | ||
| + | ||
| + // The browser env is not enabled on purpose so that code takes | ||
| + // all browser-only globals from window instead of assuming | ||
| + // they're available as globals. This makes it possible to use | ||
| + // jQuery with tools like jsdom which provide a custom window | ||
| + // implementation. | ||
| + "env": {}, | ||
| + | ||
| + "globals": { | ||
| + "window": true, | ||
| + "jQuery": true, | ||
| + "define": true, | ||
| + "module": true, | ||
| + "noGlobal": true | ||
| + }, | ||
| + | ||
| + "rules": { | ||
| + "strict": ["error", "function"] | ||
| + } | ||
| +} |
| @@ -0,0 +1,13 @@ | ||
| +{ | ||
| + "root": true, | ||
| + | ||
| + "extends": "jquery", | ||
| + | ||
| + "parserOptions": { | ||
| + "ecmaVersion": 5 | ||
| + }, | ||
| + | ||
| + "env": { | ||
| + "node": true | ||
| + } | ||
| +} |
| @@ -1,7 +1,5 @@ | ||
| { | ||
| - "extends": "eslint-config-jquery", | ||
| "root": true, | ||
| - "env": { | ||
| - "node": true | ||
| - } | ||
| + | ||
| + "extends": "./.eslintrc-node.json" | ||
| } |
| @@ -4,10 +4,10 @@ Feature Requests: | ||
| Most features should start as plugins outside of jQuery. | ||
| Bug Reports: | ||
| - Note that we only can fix bugs in the latest (1.x, 2.x, 3.x) versions of jQuery. | ||
| + Note that we only can fix bugs in the latest version of jQuery. | ||
| Briefly describe the issue you've encountered | ||
| * What do you expect to happen? | ||
| - * What acually happens? | ||
| + * What actually happens? | ||
| * Which browsers are affected? | ||
| Provide a *minimal* test case, see https://webkit.org/test-case-reduction/ | ||
| Use the latest shipping version of jQuery in your test case! | ||
| @@ -3,7 +3,6 @@ | ||
| /.editorconfig | ||
| /.gitattributes | ||
| -/.jscs.json | ||
| /.mailmap | ||
| /.travis.yml | ||
| @@ -1,7 +1,6 @@ | ||
| language: node_js | ||
| sudo: false | ||
| node_js: | ||
| -- "0.10" | ||
| -- "0.12" | ||
| - "4" | ||
| - "6" | ||
| +- "7" |
| @@ -293,3 +293,9 @@ Damian Senn <[email protected]> | ||
| Ralin Chimev <[email protected]> | ||
| Felipe Sateler <[email protected]> | ||
| Christophe Tafani-Dereeper <[email protected]> | ||
| +Manoj Kumar <[email protected]> | ||
| +David Broder-Rodgers <[email protected]> | ||
| +Alex Louden <[email protected]> | ||
| +Alex Padilla <[email protected]> | ||
| +南漂一卒 <[email protected]> | ||
| +karan-96 <[email protected]> | ||
| @@ -8,15 +8,15 @@ | ||
| Note: This is the code development repository for *jQuery Core* only. Before opening an issue or making a pull request, be sure you're in the right place. | ||
| * jQuery plugin issues should be reported to the author of the plugin. | ||
| * jQuery Core API documentation issues can be filed [at the API repo](https://github.com/jquery/api.jquery.com/issues). | ||
| -* Bugs or suggestions for other jQuery Foundation projects should be filed in [their respective repos](https://github.com/jquery/). | ||
| +* Bugs or suggestions for other jQuery organization projects should be filed in [their respective repos](https://github.com/jquery/). | ||
| ## Getting Involved | ||
| [API design principles](https://github.com/jquery/jquery/wiki/API-design-guidelines) | ||
| We're always looking for help [identifying bugs](#how-to-report-bugs), writing and reducing test cases, and improving documentation. And although new features are rare, anything passing our [guidelines](https://github.com/jquery/jquery/wiki/Adding-new-features) will be considered. | ||
| -More information on how to contribute to this and other jQuery Foundation projects is at [contribute.jquery.org](https://contribute.jquery.org), including a short guide with tips, tricks, and ideas on [getting started with open source](https://contribute.jquery.org/open-source/). Please review our [commit & pull request guide](https://contribute.jquery.org/commits-and-pull-requests/) and [style guides](https://contribute.jquery.org/style-guide/) for instructions on how to maintain a fork and submit patches. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](https://contribute.jquery.org/cla/). | ||
| +More information on how to contribute to this and other jQuery organization projects is at [contribute.jquery.org](https://contribute.jquery.org), including a short guide with tips, tricks, and ideas on [getting started with open source](https://contribute.jquery.org/open-source/). Please review our [commit & pull request guide](https://contribute.jquery.org/commits-and-pull-requests/) and [style guides](https://contribute.jquery.org/style-guide/) for instructions on how to maintain a fork and submit patches. Before we can merge any pull request, we'll also need you to sign our [contributor license agreement](https://contribute.jquery.org/cla/). | ||
| ## Questions and Discussion | ||
| @@ -13,15 +13,7 @@ module.exports = function( grunt ) { | ||
| } | ||
| var fs = require( "fs" ), | ||
| - gzip = require( "gzip-js" ), | ||
| - oldNode = /^v0\./.test( process.version ); | ||
| - | ||
| - // Support: Node.js <4 | ||
| - // Skip running tasks that dropped support for Node.js 0.10 & 0.12 | ||
| - // in those Node versions. | ||
| - function runIfNewNode( task ) { | ||
| - return oldNode ? "print_old_node_message:" + task : task; | ||
| - } | ||
| + gzip = require( "gzip-js" ); | ||
| if ( !grunt.option( "filename" ) ) { | ||
| grunt.option( "filename", "jquery.js" ); | ||
| @@ -175,7 +167,7 @@ module.exports = function( grunt ) { | ||
| "ascii_only": true | ||
| }, | ||
| banner: "/*! jQuery v<%= pkg.version %> | " + | ||
| - "(c) jQuery Foundation | jquery.org/license */", | ||
| + "(c) JS Foundation and other contributors | jquery.org/license */", | ||
| compress: { | ||
| "hoist_funs": false, | ||
| loops: false, | ||
| @@ -187,32 +179,32 @@ module.exports = function( grunt ) { | ||
| } ); | ||
| // Load grunt tasks from NPM packages | ||
| - // Support: Node.js <4 | ||
| - // Don't load the eslint task in old Node.js, it won't parse. | ||
| - require( "load-grunt-tasks" )( grunt, { | ||
| - pattern: oldNode ? [ "grunt-*", "!grunt-eslint" ] : [ "grunt-*" ] | ||
| - } ); | ||
| + require( "load-grunt-tasks" )( grunt ); | ||
| // Integrate jQuery specific tasks | ||
| grunt.loadTasks( "build/tasks" ); | ||
| - grunt.registerTask( "print_old_node_message", function() { | ||
| - var task = [].slice.call( arguments ).join( ":" ); | ||
| - grunt.log.writeln( "Old Node.js detected, running the task \"" + task + "\" skipped..." ); | ||
| - } ); | ||
| - | ||
| grunt.registerTask( "lint", [ | ||
| "jsonlint", | ||
| - runIfNewNode( "eslint" ) | ||
| + | ||
| + // Running the full eslint task without breaking it down to targets | ||
| + // would run the dist target first which would point to errors in the built | ||
| + // file, making it harder to fix them. We want to check the built file only | ||
| + // if we already know the source files pass the linter. | ||
| + "eslint:dev", | ||
| + "eslint:dist" | ||
| ] ); | ||
| grunt.registerTask( "lint:newer", [ | ||
| "newer:jsonlint", | ||
| - runIfNewNode( "newer:eslint" ) | ||
| + | ||
| + // Don't replace it with just the task; see the above comment. | ||
| + "newer:eslint:dev", | ||
| + "newer:eslint:dist" | ||
| ] ); | ||
| - grunt.registerTask( "test:fast", runIfNewNode( "node_smoke_tests" ) ); | ||
| - grunt.registerTask( "test:slow", runIfNewNode( "promises_aplus_tests" ) ); | ||
| + grunt.registerTask( "test:fast", "node_smoke_tests" ); | ||
| + grunt.registerTask( "test:slow", "promises_aplus_tests" ); | ||
| grunt.registerTask( "test", [ | ||
| "test:fast", | ||
| @@ -221,20 +213,20 @@ module.exports = function( grunt ) { | ||
| grunt.registerTask( "dev", [ | ||
| "build:*:*", | ||
| - runIfNewNode( "newer:eslint:dev" ), | ||
| + "newer:eslint:dev", | ||
| "newer:uglify", | ||
| "remove_map_comment", | ||
| "dist:*", | ||
| "compare_size" | ||
| ] ); | ||
| grunt.registerTask( "default", [ | ||
| - runIfNewNode( "eslint:dev" ), | ||
| + "eslint:dev", | ||
| "build:*:*", | ||
| "uglify", | ||
| "remove_map_comment", | ||
| "dist:*", | ||
| - runIfNewNode( "eslint:dist" ), | ||
| + "eslint:dist", | ||
| "test:fast", | ||
| "compare_size" | ||
| ] ); | ||
| @@ -1,4 +1,4 @@ | ||
| -Copyright jQuery Foundation and other contributors, https://jquery.org/ | ||
| +Copyright JS Foundation and other contributors, https://js.foundation/ | ||
| This software consists of voluntary contributions made by many | ||
| individuals. For exact contribution history, see the revision history | ||
| @@ -49,7 +49,7 @@ module.exports = function( Release ) { | ||
| generateArtifacts: function( callback ) { | ||
| Release.exec( "grunt", "Grunt command failed" ); | ||
| Release.exec( | ||
| - "grunt custom:-ajax,-effects,-deprecated --filename=jquery.slim.js && " + | ||
| + "grunt custom:-ajax,-effects --filename=jquery.slim.js && " + | ||
| "grunt remove_map_comment --filename=jquery.slim.js", | ||
| "Grunt custom failed" | ||
| ); | ||
| @@ -83,8 +83,8 @@ module.exports = function( Release ) { | ||
| }; | ||
| module.exports.dependencies = [ | ||
| - "archiver@0.14.2", | ||
| - "[email protected].0", | ||
| - "npm@2.3.0", | ||
| - "[email protected].1" | ||
| + "archiver@1.3.0", | ||
| + "[email protected].7", | ||
| + "npm@4.4.1", | ||
| + "[email protected].3" | ||
| ]; | ||
| @@ -87,7 +87,7 @@ function makeArchives( Release, callback ) { | ||
| item.replace( rver, Release.newVersion ); | ||
| } ); | ||
| - sum = Release.exec( "md5sum " + files.join( " " ), "Error retrieving md5sum" ); | ||
| + sum = Release.exec( "md5 -r " + files.join( " " ), "Error retrieving md5sum" ); | ||
| fs.writeFileSync( md5file, sum ); | ||
| files.push( md5file ); | ||
| @@ -17,7 +17,11 @@ module.exports = function( grunt ) { | ||
| read = function( fileName ) { | ||
| return grunt.file.read( srcFolder + fileName ); | ||
| }, | ||
| - wrapper = read( "wrapper.js" ).split( /\/\/ \@CODE\n\/\/[^\n]+/ ), | ||
| + | ||
| + // Catch `// @CODE` and subsequent comment lines event if they don't start | ||
| + // in the first column. | ||
| + wrapper = read( "wrapper.js" ).split( /[\x20\t]*\/\/ @CODE\n(?:[\x20\t]*\/\/[^\n]+\n)*/ ), | ||
| + | ||
| config = { | ||
| baseUrl: "src", | ||
| name: "jquery", | ||
| @@ -1,5 +1,8 @@ | ||
| { | ||
| - "extends": "../src/.eslintrc.json", | ||
| + "root": true, | ||
| + | ||
| + "extends": "../.eslintrc-browser.json", | ||
| + | ||
| "rules": { | ||
| // That is okay for the built version | ||
| "no-multiple-empty-lines": "off", | ||
Showing you all comments on commits in this comparison.
|
What do you mean? If you found a bug please report an issue with steps to reproduce. |
|
I don't really understand what you're saying. What exactly would be strange? The only thing that matters (correctness-wise) is what jQuery method for which parameter returns which value - and how it differs from what's expected. But if nothing differs then there's no problem... |
|
This breaks amd build, I'm suggesting either revert or immediate fix |
|
Fixed. |
|
(or md5sha1sum [1]) |
|
Thanks! I'll look into that. |
|
This is in the wrong position, it should follow DomEval above. |
|
This is in the wrong position, it should follow support above. |
|
This is in the wrong position, it should follow rneedsContext above. |
|
This is an old commit, hasn't this all been fixed already? |
|
Yep, i got lost in the commit history while tracking down a problem. |