Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
"Too much recursion" with jQuery 3, Firefox, and animate's complete callback. #3434
Comments
markelog
added
Effects
Needs review
labels
Dec 12, 2016
markelog
self-assigned this
Dec 19, 2016
timmywil
referenced this issue
Jan 16, 2017
Merged
9d822bc1c13dd3393b418210a99537c22c06f2c3 followup #3496
markelog
removed
the
Needs review
label
Jan 16, 2017
markelog
referenced this issue
Jan 29, 2017
Closed
RangeError: Maximum call stack size exceeded when using recursive animate while in another tab #3507
|
Yeah, this kinda, sorta by design – #1578 (comment) /cc @dmethvin, @scottgonzalez |
markelog
added
the
Needs review
label
Jan 29, 2017
timmywil
removed
the
Needs review
label
Feb 13, 2017
|
One option to try is to use page visibility api to swap rAF with setTimeout. |
added a commit
to markelog/jquery
that referenced
this issue
Mar 6, 2017
added a commit
to markelog/jquery
that referenced
this issue
Mar 6, 2017
added a commit
to markelog/jquery
that referenced
this issue
Mar 6, 2017
markelog
referenced this issue
Mar 6, 2017
Closed
Effects: stabilize rAF logic & align timeout logic with it #3559
added a commit
to markelog/jquery
that referenced
this issue
Mar 6, 2017
markelog
closed this
in
6d43dc4
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pancakeo commentedDec 6, 2016
•
Edited 1 time
-
Pancakeo
Dec 6, 2016
Versions:
Thing: I have a loading bar that animates from left-to-right, then resets. Note that it uses the complete callback (from animate) to fire itself again.
Repro:
Note that it works if I wrap the "reset" call in a setTimeout, as in:
complete: function() { setTimeout(reset, 0) }Speculation: Probably something to do with the requestAnimationFrame changes in jQuery 3? (If you leave the window focused, the recursion error does not appear).
Does NOT happen in Chrome/IE. Also, doesn't happen with jQuery 2.1.3.