/jquery

empty when resolves with 1 undefined argument in jQuery 3 (was 0 arguments in jQuery 2) #3442

Closed
i23098 opened this Issue Dec 9, 2016 · 1 comment

Comments

Assignees

@gibson042 gibson042

Labels
Projects
None yet
Milestone
  3.2.0
3 participants
@i23098 @gibson042 @mgol
@i23098

i23098 commented Dec 9, 2016

Description

I use dynamic array of deferreds to load 0 to N things and then loop through the arguments in the done callback. Upgrading to jQuery 3.1.1 from 2.2.4 and now my code breaks :(

Link to test case

Minimal test case is call $.when with no arguments, so it should resolve with no arguments too...

2.2.4 - https://jsfiddle.net/nuzy6b43/ - This will correctly have 0 arguments in the done callback
3.1.1 - https://jsfiddle.net/4qys5duk/ - This will incorrectly have 1 argument in the done callback
@gibson042
Member

gibson042 commented Dec 11, 2016

Nice catch. Thanks, @i23098!

@gibson042 gibson042 self-assigned this Dec 11, 2016

@gibson042 gibson042 added the Deferred label Dec 11, 2016

@gibson042 gibson042 added this to the 3.2.0 milestone Dec 11, 2016

gibson042 added a commit to gibson042/jquery that referenced this issue Dec 11, 2016

@gibson042
Deferred: Stop inventing jQuery.when() resolution values 
Fixes gh-3442
4ddd13a

@gibson042 gibson042 referenced this issue Dec 11, 2016

Merged

Deferred: Stop inventing jQuery.when() resolution values #3445

@mgol mgol added the Has Pull Request label Dec 13, 2016

@gibson042 gibson042 closed this in #3445 Dec 16, 2016

gibson042 added a commit that referenced this issue Dec 16, 2016

@gibson042
Deferred: Stop inventing jQuery.when() resolution values 
Fixes gh-3442
Closes gh-3445
5d79c64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment