Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Technical work of revisiting the draft and re-structuring it #2
Comments
twamarc
changed the title from
Technical work of revisiting the draft and re-structuring it: changes to data/schema.rdfa to Technical work of revisiting the draft and re-structuring it
May 30, 2015
|
Sorry I will not be able to contribute here! My 2 cents again! |
twamarc
added the
enhancement
label
Jul 17, 2015
ghost
commented
Jul 28, 2015
|
any progress there? |
|
Hi everyone, Regarding: #2 We finished the initial job of restructuring and we have generated up-to-date rdfa files both for We performed schema.org tests (scripts/run_tests.py) on the latter and they are successful. Thanks to Jos De Roo (@josd ) for his help there. The final remaining steps/tasks are: 1-To deploy on the GAE the files (schemed/HealthSchemaOrg/health_schema_org_new.rdfa & scheamaorg/data/schema.rdfa) under 'sdo-schemed.appspot.com' and 'sdo-health-schema-org.appspot.com' or other names. 2-To use the inserted subClassOf CreatedInExtension/MaintainedInCore/MovedFromCore to list all terms below each category (needed for extension rationale) 3-To take the 2 rdfa files and drop (remove) all inserted subClassOf used for classifications above: 4-To re-deploy the final cleaned files for final review @danbri: something forgotten here towards pull request? Q: Can someone provide a help there by taking over one or multiple of those tasks? Kind Regards, Marc |
danbri
commented
Jul 29, 2015
|
Thanks - you've been busy! :) /cc @RichardWallis who is working on the extensions implementation The latest implementation mechanism for extensions uses assertions such as "isPartOf http://health.schema.org/" to indicate whether something is considered to be in an extension. You can see this in the sdo-ganymede branch, and in test sites currently at http://sdo-ganymede.appspot.com and http://webschemas.org/ I'll arrange the DNS for webschemas.org (an 'upstream' unstable testing site) to have 'health' as a subdomain, for testing this. I suggest you may want to add isPartOf triples for "CreatedInExtension' and "MovedFromCore' terms. There are new unit tests to make sure each declared term has a 'home' either in Core or an extension. |
|
Great! I will add isPartOf triples for "CreatedInExtension' and "MovedFromCore' terms. Thx |
twamarc
added Fixme ASAP In progress
labels
Jul 29, 2015
RichardWallis
commented
Jul 29, 2015
|
Hi Marc, Ping me on G+ or email if I can help. Few pointers as a start (excuse if you already know this)
Any questions / issues just yell. ~Richard On Wed, Jul 29, 2015 at 2:52 PM, Marc [email protected] wrote:
|
|
Thanks Richard, indeed I need some technical help --will mail you soon for details. |
|
Hi @RichardWallis , @danbri , @josd We expect additional discussions with the Healthcare Schema Vocabulary Community Group - normally to take place next week, before we release a final copy (no big changes expected). But this pre-final release is ready to be tested at your end. Can you check out these, test in your environment and provide us a feedback? In next steps the extension will accommodate the input from #6 and #3 (/cc @ccorak @DavidXPortnoy @markwoon) . Marc |
RichardWallis
commented
Aug 18, 2015
|
Hi Marc, I'll pull this locally and produce a test health.schema.org to take a look. ~Richard
|
|
Good! Thanks Marc Sincerely yours Sent from my iPad Device
|
RichardWallis
commented
Aug 18, 2015
|
Marc, Which version of schema.rdfa did you start with - 2.0 or 2.1? ~Richard
|
ghost
commented
Aug 18, 2015
|
2.1 |
|
@jamrob the sdo-ganymede is the 2.1 |
|
@RichardWallis I see the used version is sdo-ganymede buy I see some work inside from sdo-phobos. the files in extensions will not change it would be only to check the file https://github.com/twamarc/schemaorg/blob/master/data/schema.rdfa |
RichardWallis
commented
Aug 18, 2015
|
Few points after a quick scan: Firstly 'AdmissionProcedure': Although defined as in the range Secondly the attached image highlights a few other things:
Thats all for now... ~Richard. On Tue, Aug 18, 2015 at 6:19 PM, Marc [email protected] wrote:
|
|
Thanks @RichardWallis for a quick feedback.
-additionally picked some obvious fixes in line with schemaorg/schemaorg#417 (cc/ @vholland) -Nice to have those extra error checkers (+1). Can you also add an extra constraint that domain can't be schema:text ? (don't know if it's mattering but I crossed one case once while drafting) ~ Marc |
danbri
commented
Aug 19, 2015
|
Great to see this moving along! |
danbri
commented
Aug 19, 2015
|
On the equivalence mappings aspect, we have a few external mappings in the system. AFAIK currently not exploited in the UI although we could do so trivially (e.g. in the 'more...' section). I believe we expose these mappings in per-term pages RDFa/RDFS markup.
RDFaIn per-term properties we have e.g.
In per-term type pages we have:
I presume we should be able to handle SNOMED similarly for small numbers of terms. For large external vocabularies we sometimes use the idiom that their expected type is "URL". |
mgh128
commented
Aug 19, 2015
|
Within GS1 we are developing a web vocabulary for describing product information in greater detail. Among other things, our current draft vocabulary includes properties for nutritional information for food and beverage products and also includes a nutrient basis unit property, to explicitly indicate whether the values are per 100g / 100ml of product or relative to some other quantity (e.g. a serving size or pack size of a particular weight). The nutritional properties currently include the following: gs1:biotinPerNutrientBasis Each of these can enable a manufacturer to express an amount of a particular nutrient relative to the specified nutrient basis quantity, as well as the percentage recommended daily intake value that this represents for the specified nutrient basis quantity, taking into account recommended daily intake amounts for the intended target market of the product. |
|
@danbri |
mgh128
commented
Aug 19, 2015
|
We took this approach because: (1) we are trying to ensure that anyone using the GS1 web vocabulary can do so intuitively, minimising the need to be familiar with other code lists. Of course we can link the property within our GS1 vocabulary to the corresponding concept URIs in SNOMED, HL7 or ICD. That is certainly worth doing. However, rather than having a generic property for all nutrients, we felt it was more straightforward to define one property per nutrient for the major nutrients. (2) the properties defined within http://schema.org/NutritionInformation are not sufficiently comprehensive for most nutritional properties that appear on food / beverage labels. We did refer to EU 1169/2011 food labelling legislation, to ensure that we supported the main nutrient information properties that are required to be stated for food/beverage products purchased online. (3) the properties within http://schema.org/NutritionInformation are really intended for use with a http://schema.org/Recipe and are not ideally suited for use with a http://schema.org/Product because of the ambiguity over the nutrient basis quantity. Because different regions of the world require / permit different nutrient basis quantities (e.g. per 100g / 100ml throughout the EU, versus per serving in the USA), we decided to introduce an explicit property gs1:nutrientBasisQuantity that would enable a manufacturer or brand owner to state whether the nutritional value is per 100g / 100ml or per 1 oz serving etc., leaving no ambiguity about whether they were expressed per 100g / per serving / per pack etc. In our GS1 web vocabulary, we have not created a large number of additional classes for nutritional information - instead we define one property per nutrient. We have recently been making changes to our GS1 web vocabulary to more closely align with schema.org as a potential extension - and have been having some conversations with Dan Brickley to keep him updated of these efforts. He recommended that we get in touch with you to see where we can align efforts regarding provision of detailed nutritional information for food/beverage products. |
RichardWallis
commented
Aug 19, 2015
|
Apart from how to handle the SNOMED concept URI, things are now looking So, once that issue is resolved I thing we could go to adding it into a We could do it as part of sdo-phobos, or we could do it out of band from Currently all extensions (auto, bib, health) are described as: (This is an On Wed, Aug 19, 2015 at 4:35 PM, Marc [email protected] wrote:
|
|
Nice to hear that things are now looking good for the extension--except the pending issue of how to handle the SNOMED concept URIs. |
mgh128
commented
Aug 19, 2015
|
I should also say that in addition to defining properties for nutritional information, we also define a class, gs1:AllergenType with several enumerated instances to cover the following allergens: Almond and Almond Products, Alpha-Isomethyl Ionone, Amylcinnamyl Alcohol, Amyl Cinnamal, Anise Alcohol, Barley and Barley Products, Benzyl Alcohol, Benzyl Benzoate, Benzyl Cinnamate., Benzyl Salicylate, Brazil Nut and Brazil Nut Products, Butylphenyl Methylpropionate., Carrot and Derivatives, Cashew and Cashew Products, Celery or Derivatives, Cereals Containing Gluten and Their Derivatives, Cinnamal, Cinnamyl Alcohol, Citral, Citronellol, Cocoa and Derivatives, Coriander Derivatives, Corn and Derivatives, Coumarin, Crustaceans and Their Derivatives, Eggs and Their Derivatives, Eugenol, Evernia Furfuracea, Evernia Prunastri, Farnesol, Fish and Their Derivatives, Geraniol, Gluten, Hazelnut and Hazelnut Products, Hexyl Cinnamal, Hydroxycitronellal, Hydroxyisohexyl 3-Cyclohexene Carboxaldehyde Isoeugenol Limonene Linal, Kamut and Kamut Products, Lactose, Lupine and Derivatives, Macadamia Nut and Macadamia Nut Products, Methyl 2-Octynoate, Milk and Derivatives, Molluscs and Their Derivatives, Mustard and Derivatives , Oat and Oat Products, Peanuts and Their Derivatives, Peas and Pea Products, Pecan Nut and Pecan Nut Products, Pistachio and Pistachio Products, Pod Fruits Derivatives, Queensland Nut and Queensland Nut Products, Rye and Derivatives, Sesame Seeds or Their Derivatives, Soybeans and Their Derivatives, Spelt and Spelt Products, Sulphur Dioxide and Sulphites, Tree Nuts and Their Derivatives, Traces of Tree Nuts, Walnut and Walnut Products, Wheat and Their Derivatives We also define a class gs1:NutritionalClaimTypeCode with instances to indicate declared nutritional claims including: "Additive Free", "Artificially Sweetened", "Cholesterol Free", "Colouring Agent Free", "Contains Glyzyrrhizin", "Contains Liquorice", "Contains Soy", "Egg Free", "Energy Free", "Energy Reduced", "Enriched or Fortified in Vitamins Minerals", "Fat Free", "Free From Gluten", "Guarantee Lactose Free", "High Fibre", "High Protein", "High in Vitamins Minerals", "Lactose Free", "Light or Lite", "Low Energy", "Low Protein", "Low in Fat", "Low in Lactose", "Low in Saturated Fat", "Low in Sodium", "Low in sugars", "Milk Free", "Milk Protein Free", "Natural Source of Vitamins Minerals", "No Added Sugar", "Non-alcoholic", "Nut Free", "Peanut Free", "Preservative Free", "Saturated Fat Free", "Sodium of Salt Free", "Source of Fibre", "Source of Protein", "Soy Free", "Strongly Salted", "Sugar Free", "Sweetened With Agave Syrup", "Sweetened With Came Sugar", "Sweetened With Corn Syrup", "Sweetened With Fructose", "Sweetened With Fruit Juice", "Sweetened With Fruit Syrup", "Sweetened With Honey", "Sweetened With Malt", "Sweetened With Raw Beet Sugar", "Sweetened With White Sugar", "Very Low Gluten", "Very Low in Sodium Salt", "Wheat Free" We also define a gs1:DietTypeCode with instances to represent the following: "Coeliac","Dietetic","Free From Gluten","Halal","Kosher","Organic","Vegan","Vegetarian","Without Beef","Without Pork" We have further properties to enable manufacturers and brand owners to specify which independent accreditation organisation verified the claims for products (whether dietary / health, ethical or environmental) |
danbri
commented
Aug 19, 2015
|
/cc @rvguha fyi |
|
Hi @RichardWallis, I tested locally, it's OK . Can you check at your side? At the same time I complied all info about global overview of the vocabulary (terms inventory) and the file is accessible in GitHub as well: Hope to talk with you all tomorrow. |
RichardWallis
commented
Aug 27, 2015
|
The RDFa descriptions are now looking good enough to add to the schemaorg There are a few problems with the examples - naming of, and labeling Lets talk through with @danbri when and which branch we use for this, and Hoping to attend tomorrow, so maybe we can discuss some of this then. ~Richard On Thu, Aug 27, 2015 at 4:30 PM, Marc [email protected] wrote:
|
rvguha
commented
Aug 28, 2015
|
Marc, Can you post a summary of the changes you are proposing, so that we can guha On Thu, Aug 27, 2015 at 4:22 PM, RichardWallis [email protected]
|
|
@rvguha : Can this quoted before file be enough? It shows a global overview of the vocabulary (terms inventory) + summary of changes (terms moved from the core to the extension, terms created in the extension, terms to be discussed, etc.) in Google docs: It's a little bit big to post it here, let me know if it is what you expected @RichardWallis / Marc |
RichardWallis
commented
Aug 28, 2015
|
Marc, Take a look at: http://health.sdo-schemedex.appspot.com/Diagnosis Examples changes not in this version ~Richard On Fri, Aug 28, 2015 at 9:16 AM, Marc [email protected] wrote:
|
|
Hi Richard, Thx |
RichardWallis
commented
Aug 28, 2015
|
Yes you can use. I'll be there! ~Richard
|
danbri
commented
Aug 28, 2015
|
@twamarc the overview document is useful, but we should also have some high level overview of the (scope, purpose, coverage etc.) for the many new terms added in the extension. This looks like the best summary so far: https://drive.google.com/file/d/0B3XqWCPGZuTeUTV6ZnVnYjBqdEU/view?pli=1 (via https://drive.google.com/folderview?id=0B3XqWCPGZuTeTGc2ZlVxRXZhYWM&usp=sharing with some other useful files) I'll post an extract from that document here:
|
|
@danbri Thanks. I will update this file as well to meet all current structures of the extension. |
danbri
commented
Aug 28, 2015
|
I made some rough (and very very partial) notes on one issue: the exact choice of name for each term. This is probably not the best place for that review but just to quickly share, I copy below. The basic idea is that we need to avoid "using up" words for health that may be more generally applicable, and that we should also look for opportunities to integrate with the core, and for difficult areas where extension schemas overlap (e.g. food/nutrition). Rough notes on term choiceWe should consider if we move Place / LocalBusiness -related types: Dentist Hospital Optician Pharmacy Physician Clinician etc (Dentistry vs Dentist?) (some of these are also person-as-organization awkward) Diet, DietarySupplement ...
I don't think Recipe should move to health from core - although there is clearly a connection
propose adding muscleAction instead, and potentially removing the medical sense of 'action' (deprecate). The other sense is served ok by potentialAction already.
e.g. Vessel, Appearance, Balance, CT, Completed, Emergency, Genetic, body parts (Ear, Head, ...?), MRI (e.g. MRIScan? MRIScanning?), Retail (rel. to ecommerce vocab?), (noting that there is still a sense in which the namespace is flat; both in terms of term allocation, and eventual markup)
action
activityDuration
affectedBy, availableIn, cost, warning, ....
birthPlace
calories
code
|
ghost
commented
Aug 29, 2015
|
+1 |
This was referenced Sep 2, 2015
|
I clossed this issue, is done. |
twamarc commentedMay 30, 2015
While we are preparing the health.schema.org extension, we need to revisit and restructure the initial submitted draft. A couple of predicates/classes have been already added in schema.org; and we need to list some predicates which will be moved to extension from core and vice versa.
The current RDFa file:
https://github.com/twamarc/ScheMed/blob/master/medicalEntity.rdfa
On the TO DO list we have also to document the following:
-The following terms are moved (todo: list).
-The following terms are renamed (todo: list) with the core.
-The following terms are renamed (todo: list) and moved into the extension.
-The following terms are created (todo: list) within the core.
-The following terms are created (todo: list) within the extension.
-The following somewhat medically-related terms remain in the core (todo: list, e.g. http://schema.org/Recipe).
-The following extension-related discussions are noted as relevant (todo: list, e.g. GS1, nutrition/food, ...).
-The following related standards groups have been identified and invited to comment. (todo: list).