If draft page selected for Privacy Policy page should verbiage change from view to preview

[garrett-eclipse]

Hello,

Super minor, but should the verbiage on the Privacy Settings page switch from view to preview when the page you've selected for Privacy Policy page is in draft mode?

See screen for verbiage I'm speaking on, it's the 'Edit or view your privacy policy page content.'

Cheers

[garrett-eclipse]

View vs Preview link

[desrosj]

Marking Privacy change as introduced in 4.9.6.

[desrosj]

Screenshot with a bit more context

[desrosj]

Switch conditions and check for publish instead of draft.

[desrosj]

44131.2.diff​ adjusts the text to read "preview" instead of "view" when the selected privacy policy page is not published.

I originally checked if a page was in draft status, but then thought about pages that may have other statuses. Scheduled pages should also read "preview", so switching the condition to check if a page is publish will also display "preview" for scheduled pages.

One other instance to consider is private pages. While private, and scheduled are not supported by default, it is possible to select a published page and then change it to private or scheduled.

When a page is move to the trash, the user does see a notice on the Settings > Privacy page (screenshot incoming).

I opened #44320 to explore how we are notifying users of issues with their site's privacy policy a bit further.

[desrosj]

Behavior when Privacy Policy is trashed.

[garrett-eclipse]

Niiice this is awesome thanks @desrosj

[azaozz]

In 43374:

Privacy: on the Privacy Settings screen change view to preview when a draft page is selected for the privacy policy.

Props garrett-eclipse, desrosj.
Fixes #44131.

[azaozz]

Reopen for 4.9.7.

[ocean90]

4.9.7 has been released, moving to next milestone.

[SergeyBiryukov]

In 43453:

Privacy: on the Privacy Settings screen change view to preview when a draft page is selected for the privacy policy.

Props garrett-eclipse, desrosj.
Merges [43374] to the 4.9 branch.
Fixes #44131.

[garrett-eclipse]

Not sure if this will be corrected when #44130 is committed but I came across the verbiage this ticket introduced and found it didn't follow the correct case as outlined in comment 7 on that ticket;

"Privacy Policy" in this instance is a proper noun and "page" is a common noun. So, the standard should be "Privacy Policy page."

Reference - https://core.trac.wordpress.org/ticket/44130#comment:7

So this verbiage;

<a href="%1$s">Edit</a> or <a href="%2$s">preview</a> your privacy policy page content.

Should actually be;

<a href="%1$s">Edit</a> or <a href="%2$s">preview</a> your Privacy Policy page content.

*With Privacy Policy capitalized.

Permalink - ​https://translate.wordpress.org/projects/wp/dev/admin/en-ca/default?filters%5Boriginal_id%5D=6385590

[SergeyBiryukov]

Replying to garrett-eclipse:

So this verbiage;

<a href="%1$s">Edit</a> or <a href="%2$s">preview</a> your privacy policy page content.

Should actually be;

<a href="%1$s">Edit</a> or <a href="%2$s">preview</a> your Privacy Policy page content.

*With Privacy Policy capitalized.

The patch on #44130 includes a fix for this.

[garrett-eclipse]

Thanks for catching @SergeyBiryukov