Mixed Case of Privacy Policy on Privacy Settings page

[garrett-eclipse]

Hello,

Super minor sorry didn't catch earlier, but seeing a mix of cases for Privacy Policy on the Privacy Settings. There's 'Privacy policy page', 'privacy policy page' and 'Privacy Policy page'. See attached screen.

Not sure what the rule of thumb is there or if this is introduced in en_CA as I'm on that locale.

Thanks

[garrett-eclipse]

Mixed case for Privacy Policy page

[joyously]

I think most of them should be lowercase. The heading looks OK to me mixed. The one near the bottom that starts with "Need help" should probably be lowercase. The questionable one is the last one "Change your Privacy Policy page". I can see it either way.

[desrosj]

Marking Privacy change as introduced in 4.9.6.

[desrosj]

Assigning to @XpertOne to mark good-first-bug claimed.

@idea15, what is your opinion on proper casing here? Personally, I think that page should be lower cased, except in the page title.

[idea15]

@desrosj

"Privacy Policy" in this instance is a proper noun and "page" is a common noun. So, the standard should be "Privacy Policy page."

[ocean90]

4.9.7 has been released, moving to next milestone.

[desrosj]

@XpertOne are you able to refresh the patch based on @idea15's feedback?

[XpertOne]

@desrosj yes I will do that shortly.

[XpertOne]

@desrosj I have refreshed the patch.

[pbiron]

Any chance this can land in 4.9.8 (beta releasing is scheduled for July 17, next Tues)?

[garrett-eclipse]

In latest set of strings I found 2 instances of incorrect cases.

1. '<a href="%1$s">Edit</a> or <a href="%2$s">preview</a> your privacy policy page content.'

This should have capitalization here - 'Privacy Policy page' Permalink - ​https://translate.wordpress.org/projects/wp/dev/admin/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=6385590&filters%5Btranslation_id%5D=56241004 *I've already reported this on #44131 to be addressed there if possible.

2. 'Privacy Policy Page'

The page should be lowercase, so string should be - 'Privacy Policy page' Permalink - ​https://translate.wordpress.org/projects/wp/dev/admin/en-ca/default?filters%5Boriginal_id%5D=6385588

[SergeyBiryukov]

Replying to garrett-eclipse:

In latest set of strings I found 2 instances of incorrect cases.

1. '<a href="%1$s">Edit</a> or <a href="%2$s">preview</a> your privacy policy page content.'

This should have capitalization here - 'Privacy Policy page' Permalink - ​https://translate.wordpress.org/projects/wp/dev/admin/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=6385590&filters%5Btranslation_id%5D=56241004 *I've already reported this on #44131 to be addressed there if possible.

44130.2.diff​ appears to include a fix for this.

2. 'Privacy Policy Page'

The page should be lowercase, so string should be - 'Privacy Policy page' Permalink - ​https://translate.wordpress.org/projects/wp/dev/admin/en-ca/default?filters%5Boriginal_id%5D=6385588

This was done for consistency with other "special" page suffixes in the list table, i.e. "Posts Page" and "Front Page". See the discussion in #44006.

[SergeyBiryukov]

44130.2.diff​ seems good to go.

[garrett-eclipse]

Thanks @SergeyBiryukov I missed that, makes complete sense in that context.

[SergeyBiryukov]

In 43508:

Privacy: Use a consistent case for "Privacy Policy page" on Privacy Settings screen.

Props XpertOne, idea15, garrett-eclipse.
Fixes #44130.

[SergeyBiryukov]

In 43509:

Privacy: Use a consistent case for "Privacy Policy page" on Privacy Settings screen.

Props XpertOne, idea15, garrett-eclipse.
Merges [43508] to the 4.9 branch.
Fixes #44130.