Differential D2484

Bug 1461515 - Split tracking annotations from tracking protection. r?dimi
ClosedPublic
Actions

Authored by francois on Fri, Jul 27, 10:46 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRAL3715363d32cb: Bug 1461515 - Split tracking annotations from tracking protection. r=dimi

Bugzilla Bug ID

Summary

This makes it possible to use different lists for tracking protection
and for the features that rely on tracking annotations.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

francois created this revision.Fri, Jul 27, 10:46 PM

Herald added a project: Restricted Project. · View Herald TranscriptFri, Jul 27, 10:46 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Fri, Jul 27, 10:46 PM

phab-bot changed the edit policy from "Custom Policy" to "All Users".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B3425: Diff 6055.Fri, Jul 27, 10:46 PM

francois requested review of this revision.Fri, Jul 27, 10:46 PM

francois added a child revision: D2485: Bug 1461515 - Fix and expand tracking annotation test. r?dimi.Fri, Jul 27, 10:53 PM

francois updated this revision to Diff 6145.Mon, Jul 30, 9:27 PM

This comment was removed by francois.

Harbormaster completed remote builds in B3492: Diff 6145.Mon, Jul 30, 9:27 PM

francois updated this revision to Diff 6149.Mon, Jul 30, 9:44 PM

This comment was removed by francois.

Harbormaster completed remote builds in B3494: Diff 6149.Mon, Jul 30, 9:44 PM

Hopefully restore the correct patch this time (sigh)

Harbormaster completed remote builds in B3495: Diff 6150.Mon, Jul 30, 9:46 PM

Looks good, thanks!

netwerk/base/nsChannelClassifier.cpp
939–940	I think this function is a little bit complicated because it took me a while to figure out that we will call this twice and the related logic behind it. I think it will be good if we could add more comments in this function.
1286–1295	s/nsCString/nsAutoCString
1419–1429	s/nsCString/nsAutoCString

This revision is now accepted and ready to land.Wed, Aug 1, 10:58 AM

Address Dimi's review comments.

Harbormaster completed remote builds in B3649: Diff 6375.Wed, Aug 1, 8:45 PM

Closed by commit rMOZILLACENTRAL3715363d32cb: Bug 1461515 - Split tracking annotations from tracking protection. r=dimi (authored by francois, committed by ). · Explain WhyWed, Aug 1, 8:48 PM

This revision was automatically updated to reflect the committed changes.

francois marked 3 inline comments as done.

Revision Contents
Changeset List

			Path	Packages
M			modules/libpref/init/all.js (2 lines)
M			netwerk/base/nsChannelClassifier.h (4 lines)
M			netwerk/base/nsChannelClassifier.cpp (327 lines)
M			toolkit/components/url-classifier/Classifier.cpp (5 lines)
M			toolkit/components/url-classifier/SafeBrowsing.jsm (34 lines)
M			toolkit/components/url-classifier/nsUrlClassifierDBService.cpp (2 lines)
M			toolkit/components/url-classifier/tests/UrlClassifierTestUtils.jsm (18 lines)
M			toolkit/components/url-classifier/tests/mochitest/test_trackingprotection_bug1312515.html (2 lines)
M			xpcom/base/ErrorList.py (2 lines)

Diff 6376

modules/libpref/init/all.js

Loading...

netwerk/base/nsChannelClassifier.h

Loading...

netwerk/base/nsChannelClassifier.cpp

Loading...

toolkit/components/url-classifier/Classifier.cpp

Loading...

toolkit/components/url-classifier/SafeBrowsing.jsm

Loading...

toolkit/components/url-classifier/nsUrlClassifierDBService.cpp

Loading...

toolkit/components/url-classifier/tests/UrlClassifierTestUtils.jsm

Loading...

toolkit/components/url-classifier/tests/mochitest/test_trackingprotection_bug1312515.html

Loading...

xpcom/base/ErrorList.py

Loading...