Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
[css-sizing] Intrinsic size of replaced elements incorrect #794
Comments
fantasai
added
the
css-sizing-3
label
Dec 7, 2016
fantasai
referenced this issue
Dec 19, 2016
Closed
[css-grid] Stretching image grid items in both dimensions #523
added a commit
that referenced
this issue
Dec 19, 2016
fantasai
added
the
Agenda+
label
Dec 19, 2016
|
Agenda+ to point out that the implication here is that, when an aspect ratio is present, |
|
I really don't want Doing so could cause problems down the road if we ever add the ability for calc() expressions to reference concepts like "this element's |
|
The problem with that is then we don't have a keyword for "shrinkwrap this thing as if it was a float with (infinite/minimal space)", which is what you generally want in e.g. grid track sizing. |
fantasai
added
Agenda+ F2F
and removed
Agenda+
labels
Jan 4, 2017
astearns
removed
the
Agenda+ F2F
label
Jan 11, 2017
|
I just discussed this a bit with @fantasai. To clarify what I want instead: I'd like the I don't think the grid track sizing thing is an issue, since that should be depending on the min-content contribution, which is affected by the aspect ratio with either proposal. @fantasai's approach has the advantage (for the spec authors, and maybe implementors) that defining what There isn't a distinct author feature in @fantasai's proposal, I don't think; I still think my proposal is more future-proof for features like the ones I described above in #794 (comment) |
tabatkins
added
the
Agenda+ F2F
label
Jul 18, 2017
astearns
removed
the
Agenda+ F2F
label
Aug 1, 2017
|
Propose to close as fixed, after f2f discussions with dbaron in SF. |
fantasai
closed this
Aug 3, 2017
fantasai
reopened this
Aug 3, 2017
fantasai
added
the
Agenda+
label
Aug 9, 2017
css-meeting-bot
commented
Aug 16, 2017
|
The CSS Working Group just discussed
The full IRC log of that discussion<dael> Topic: Intrinsic size of replaced elements incorrect<dael> github topic https://github.com/w3c/csswg-drafts/issues/794 <dael> github: https://github.com/w3c/csswg-drafts/issues/794 <dael> fantasai: There's a definition in the sizing spec about what the min and max content size of images are. We defined to account for sizing constriant in opposite axis. We're defining by reference to css 2.1 <dael> fantasai: dbaron wanted these keywords to represent actual intrinisic size. I spoke with him and he said givent he way impl behave in grid he's unhappy about defining it that way be is okay. As far as the definition dbaron wants we can add another set of keywords if authors want to express that. <dael> fantasai: Seems unlikely as an author want, but might be useful for Houdini things. <dael> dbaron: I think that's a reasonable summary. <dael> fantasai: If everyone is happy with the state we can close as we've defined the sizing. <dael> Chris: Objections? <dael> Chris: Anyone need time to think? <dael> RESOLVED: Close the issue |
fantasai commentedDec 7, 2016
Currently Sizing 3 defines intrinsic sizes of replaced elements explicitly.
This definition isn't correct, and it should be deleted in favor of falling through to the CSS2.1 reference used for non-replaced elements.