Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
[css-fonts] font-feature-settings property should be reset by font shorthand #1349
Comments
upsuper
added
the
css-fonts-3
label
May 11, 2017
|
(I tried to do the edit myself for this and #1032 but I failed... I don't know how to generate |
|
I believe the fonts spec is still generated using Bert's preprocessor because bikeshed doesn't understand descriptors vs. properties with the same name. It's also worth noting that Gecko has always implemented it this way -- |
|
Yes, Fonts 3 uses the old pre-bikeshed processor (I think only this spec and CSS 2.2 or whatever wer are calling it this week still use the old preprocessor). I agree that font-feature-settings should be reset by the font shorthand. |
|
Just FYI - the Bikeshed conversion of css-fonts-3 is tracked in #234. |
litherum
added
the
Needs Edits
label
May 15, 2017
|
Also the new property "font-variation-settings" in CSS Fonts 4 should be reset by font shorthand as well, I believe. |
litherum
added
the
css-fonts-4
label
May 24, 2017
|
If we're going to do |
litherum
referenced this issue
Jul 21, 2017
Closed
[css-fonts-4] Which font properties should be reset by the font shorthand? #1636
|
According to #1636 (comment), Gecko is the only engine which sets this. |
fantasai
added
the
Agenda+
label
Aug 2, 2017
|
Adding to F2F agenda, so removing Agenda+ |
No, it understands them just fine. You do have to be more explicit about autolinking, so it knows whether you're referring to the property or the descriptor. (The old preprocessor doesn't complain, it just silently links all of them to a single arbitrarily-chosen definition. In other words, it's wrong for a lot of the links.) |
css-meeting-bot
commented
Aug 3, 2017
|
The CSS Working Group just discussed The full IRC log of that discussion<fremy> Topic: Properties being reset by the font shorthand<myles_> https://github.com/w3c/csswg-drafts/issues/1636#issuecomment-317127312 <fremy> myles_: I made an amazing table, let me paste the link <fremy> myles_: there seems to be consensus that the font shorthand resets what is not specified in it <fremy> myles_: but what the other things are doesn't seem interoperable <fremy> dbaron: I think the test is wrong for font-language-override <fremy> myles_: let me check <fremy> TabAtkins: there seems to be things we do support that this test says we dont <fremy> TabAtkins: so we cannot trust this data <TabAtkins> font-size-adjust, at minimum - we def support it (it causes the CSSWG blog to display brokenly on a Chromebook >_<) <fremy> myles_: ok, we will discuss this another day then <myles_> https://github.com/w3c/csswg-drafts/issues/1579 |
|
Duplicate of #1636 |
litherum
marked this as
a duplicate of
#1636
Aug 3, 2017
litherum
closed this
Aug 3, 2017
css-meeting-bot
commented
Sep 6, 2017
|
The Working Group just discussed The full IRC log of that discussion<dael> Topic: font-feature-settings property should be reset by font shorthand<dael> Github: https://github.com/w3c/csswg-drafts/issues/1349 <dael> many: thought we resolved that <fantasai> https://lists.w3.org/Archives/Public/www-style/2017Aug/0042.html <dael> Rossen_: It was agenda+ on Aug 2 and I guess it wasn't removed. <fantasai> " <fantasai> - RESOLVED: All font-* properties are reset by the font shorthand, <fantasai> except font-presentation and font-synthesis." |
upsuper commentedMay 11, 2017
Given that subproperties of
font-variantare all reset byfontshorthand, I think it's pretty apparentlyfont-feature-settingsshould be as well. It makes no sense to apply the same set of settings when the font is changed.