Animated GIF support. #115

Merged
merged 1 commit into from Dec 7, 2016

Projects

None yet

2 participants

@timonus
Contributor
timonus commented Aug 21, 2016

Untested at the moment, but I believe this brings animated GIF support to the PDK.

@timonus timonus Add support for pinning image data.
Implicitly supports animated GIFs.
efb0bf0
@timonus
Contributor
timonus commented Dec 2, 2016

Alright, verified that this works. I made this pin using this branch of the PDK. Sadly, looks like our service isn't recognizing it as a GIF at the moment (I've fixed that before and will again), but if you click through to the underlying image you'll see it's a GIF.

@timonus
Contributor
timonus commented Dec 2, 2016

cc @rahul-malik, who pinged me to update this today :) @levi any chance I could land this?

@rahul-malik
Member

Discussed with @timonus in person but leaving feedback here to associate with the thread.

I can merge this PR when we successfully have a GIF pin created. Although we are uploading a GIF the API is not creating the correct pin type and the GIF does not actually play. When this is resolved I'll help merge this PR.

@timonus
Contributor
timonus commented Dec 6, 2016

Alright, the pin I attached in the former comment is now being properly recognized as a GIF, and new pins I create are also working (example here). I think this is ready to land @rahul-malik.

@rahul-malik rahul-malik merged commit e3183d1 into pinterest:master Dec 7, 2016
@timonus timonus referenced this pull request Dec 12, 2016
Closed

Animated GIF support #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment