Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5274 Create visual distinction between exclusion and inclusion checkboxes #3200

Merged
merged 11 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
Owner

sarken commented Dec 6, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5274

Purpose

Uses this technique to update the styling of the input elements on our filters with the specific goal of making it easier to tell if the selected item is selected for inclusion or exclusion as you scroll down the page.

Testing

Refer to JIRA

sarken added some commits Dec 4, 2017

AO3-5274 Distinguish exclusion filters from inclusion filters
TODO: Update HTML of all other filter partials
TODO: Better styling for radio buttons
AO3-5274 Use helper method for generating label contents
Also put the indicator in a separate span so it can be hidden from screen readers

@elzj elzj merged commit d208448 into otwcode:master Dec 7, 2017

4 checks passed

Scrutinizer 1 new issues
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment