Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5273: Fix child queries for bookmark filter data #3197
Conversation
| - { has_child: { type: "bookmark", query: filter } } | ||
| + key = options[:type] == :exclusion ? :exclude : :include | ||
| + child_filters[key] << filter | ||
| + return nil |
| @@ -0,0 +1,26 @@ | ||
| +require 'spec_helper' |
elzj
added
Awaiting review
Priority: Broken on Test (High)
labels
Dec 4, 2017
sarken
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Dec 5, 2017
sarken
merged commit 754efba
into
otwcode:master
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
elzj commentedDec 4, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5273
Purpose
Fixes an issue where private bookmarks were being counted in filters if the work/series had other public bookmarks.
Because works/series/external works can have multiple bookmarks, the child filters have to be combined into one query of their own or else incorrect results may be returned.
Testing
See issue.