Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5264: Set operator for bookmark search #3195
Conversation
| @@ -5,7 +5,7 @@ | ||
| it "should allow you to perform a simple search" do | ||
| q = BookmarkQuery.new(query: "unicorns") | ||
| search_body = q.generated_query | ||
| - expect(search_body[:query][:bool][:should]).to include({:query_string => { :query => "unicorns" }}) | ||
| + expect(search_body[:query][:bool][:should]).to include({ query_string: { query: "unicorns", default_operator: "AND" }}) |
elzj
added
Awaiting review
Priority: Broken on Test (High)
labels
Dec 2, 2017
redsummernight
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Dec 2, 2017
otw-deploy
merged commit dc3426c
into
otwcode:master
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
elzj commentedDec 2, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5264
Purpose
Fixes bookmark search to use 'AND' as the default operator, to match other search behavior.
Testing
Bookmark searches for multiple words/terms should return results that match all of them, not any one of them.