Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5229: Simple fix for ancient date errors #3190
Conversation
| def self.time_from_string(amount, period) | ||
| - amount.to_i.send(period).ago | ||
| + date = amount.to_i.send(period).ago | ||
| + date.year < 0 ? 1000.years.ago : date |
elzj
added
Awaiting review
Priority: Broken on Test (High)
labels
Nov 30, 2017
|
redsummernight gave the thumbs-up in chat, so merging! |
sarken
merged commit ed19127
into
otwcode:master
Dec 1, 2017
redsummernight
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
elzj commentedNov 30, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5229
Purpose
Fix error encountered when a user enters a very large date in date search. Since we're really just concerned with things posted by contemporaneous people, a simple fix should suffice for now.
Testing
Entering a large value in date search should no longer error.