/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5230 Fix range filters in bookmark search #3184

Merged
merged 1 commit into from Nov 29, 2017
+80 −6

Conversation

Reviewers

@elzj elzj

Assignees
No one assigned
Labels
Priority: Broken on Test (High) Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
3 participants
@redsummernight @elzj @zz9pzza
@redsummernight
Contributor

redsummernight commented Nov 28, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5230

Purpose

  • Parse date updated and date bookmarked filters
  • Unescape < and > characters
  • Avoid re-escaping < and > characters in search summary
  • Remove unused references to "bookmarkable_word_count"

Testing

See issue.
@redsummernight
AO3-5230 Fix range filters in bookmark search 
- Parse date updated and date bookmarked filters
- Unescape < and > characters
- Avoid re-escaping < and > characters in search summary
- Remove unused references to "bookmarkable_word_count"

Some checks were not successful

1 failing, 1 pending, and 2 successful checks
codeclimate — 3 issues to fix
Details
hound — Hound is busy reviewing changes...
Scrutinizer — 8 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
2f82e98

@redsummernight redsummernight added the Awaiting review label Nov 28, 2017

@elzj elzj added the Priority: Broken on Test (High) label Nov 29, 2017

@elzj

elzj approved these changes Nov 29, 2017
View changes

@elzj elzj added Reviewed: Ready to Merge and removed Awaiting review labels Nov 29, 2017

@zz9pzza zz9pzza merged commit bdefd7c into otwcode:master Nov 29, 2017
2 of 4 checks passed

2 of 4 checks passed

codeclimate 3 issues to fix
Details
hound Hound is busy reviewing changes...
Scrutinizer 8 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@redsummernight redsummernight deleted the redsummernight:AO3-5230-bkmk-range branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment