/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5192: Add sites to https list, rescue to after task #3099

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Reviewers

@houndci-bot houndci-bot

@zz9pzza zz9pzza

@sarken sarken

Assignees
No one assigned
Labels
Priority: Broken on Test (High) Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
3 participants
@elzj @zz9pzza @houndci-bot
@elzj
Owner

elzj commented Oct 4, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5192

Purpose

Expand https list

Testing

See issue
@elzj
AO3-5192: Add sites to https list, rescue to after task

All checks have passed

4 successful checks
Scrutinizer — No new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — 1 violation found.
9d31b02
lib/tasks/after_tasks.rake
@@ -568,9 +568,16 @@ namespace :After do
desc "Enforce HTTPS where available for embedded media"
task(enforce_https: :environment) do
Chapter.find_each do |chapter|
+ if chapter.id % 1000 == 0
@houndci-bot

houndci-bot Oct 4, 2017

Use (chapter.id % 1000).zero? instead of chapter.id % 1000 == 0.

@elzj elzj added Awaiting review Priority: Broken on Test (High) labels Oct 4, 2017

@elzj elzj requested review from sarken and zz9pzza Oct 4, 2017

@zz9pzza zz9pzza added Reviewed: Ready to Merge and removed Awaiting review labels Oct 4, 2017

@zz9pzza zz9pzza merged commit fc42034 into otwcode:master Oct 4, 2017
4 checks passed

4 checks passed

Scrutinizer No new issues
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound 1 violation found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment