AO3-4187 Fix empty tag dropdown when filtering news posts #3092

Merged
merged 1 commit into from Nov 25, 2017

Conversation

Projects
None yet
6 participants
Contributor

redsummernight commented Oct 2, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-4187

Purpose

When filtering news posts, if a language is selected, the tag dropdown will have all tags across all posts of that language, instead of being empty.

Testing

See issue.

AO3-4187 Fix empty tag dropdown when filtering news posts
If a language is selected, the dropdown will have all tags across
all posts of that language.
@@ -310,7 +290,7 @@ def update_settings(settings)
### THEN
-When (/^I make a translation of an admin post$/) do
+When (/^I make a translation of an admin post( with tags)?$/) do |with_tags|
@houndci-bot

houndci-bot Oct 2, 2017

(...) interpreted as grouped expression.

@otw-deploy otw-deploy closed this Oct 31, 2017

@zz9pzza zz9pzza reopened this Oct 31, 2017

@elzj elzj merged commit 491399d into otwcode:master Nov 25, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer 6 new issues
Details
codeclimate All good!
Details
hound 1 violation found.

@redsummernight redsummernight deleted the redsummernight:AO3-4187-news-tag-select branch Nov 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment