Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-4138 make reading history more linguistically accessible #3081
+20
−20
Conversation
sarken
added
the
Awaiting review
label
Sep 26, 2017
sarken
approved these changes
Sep 26, 2017
Looks good!
If you have time, would you change the syntax from :date => set_format_for_date(reading.last_viewed) to date: set_format_for_date(reading.last_viewed) in the blurb file?
If you don't have time, no worries!
|
no worries! i can do that. |
pupupuri
added some commits
Sep 27, 2017
sarken
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Sep 28, 2017
|
Terrific -- thank you! |
otw-deploy
closed this
Oct 31, 2017
zz9pzza
reopened this
Oct 31, 2017
elzj
merged commit b284f6e
into
otwcode:master
Nov 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pupupuri commentedSep 26, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-4138
Purpose
in reading history, changes "last viewed: (date)" and "viewed: (number)" to "last visited" and "visited"
Testing
please go to your reading history and confirm that the text bar under each work in your history now says "last visited: (date)" and "visited: (number)"
References
the initial pr was closed; sorry about that