/otwarchive

AO3-5183 Index preferences on skin_id #3074

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Reviewers

@houndci-bot houndci-bot

@ariana-paris ariana-paris

Assignees
No one assigned
Labels
Has Migrations Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
3 participants
@sarken @ariana-paris @houndci-bot
@sarken
Owner

sarken commented Sep 22, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5183

Purpose

Adds an index to the preferences table in hopes that it will speed up the approved skins page enough for us to access it again.

Testing

Can't really be tested
@sarken
AO3-5183 Index preferences on skin_id

All checks have passed

4 successful checks
Scrutinizer — 2 updated code elements
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — 1 violation found.
686ca39

@sarken sarken added the Awaiting review label Sep 22, 2017

db/migrate/20170922234741_add_index_to_preferences.rb
@@ -0,0 +1,5 @@
+class AddIndexToPreferences < ActiveRecord::Migration[5.1]
@houndci-bot

houndci-bot Sep 22, 2017

Missing magic comment # frozen_string_literal: true.

@ariana-paris ariana-paris added Reviewed: Ready to Merge and removed Awaiting review labels Sep 24, 2017

@ariana-paris

ariana-paris approved these changes Sep 24, 2017
View changes

More indexes 👍

@sarken sarken added the Has Migrations label Oct 2, 2017

@sarken sarken merged commit a180826 into otwcode:master Oct 6, 2017
4 checks passed

4 checks passed

Scrutinizer 2 updated code elements
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound 1 violation found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment