/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5149 ePub files do not open because they contain Ruby #3033

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting review Priority: Critical
Projects
None yet
Milestone
No milestone
2 participants
@sarken @elzj
@sarken
Owner

sarken commented Sep 8, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5149

Purpose

Fixes a problem with ePub files not opening by making sure the Ruby in two files gets evaluated before we make the ePubs.

Testing

Refer to JIRA

sarken added some commits Sep 8, 2017

@sarken
AO3-5149 Table of contents file templates for epub need to indicate t… 
…hey have Ruby, so the Ruby gets evaluated when we make the epub
d08baac
@sarken
Merge branch 'master' into AO3-5149

Some checks were not successful

1 errored and 3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
Scrutinizer — No new issues
Details
codeclimate — All good!
Details
hound — No violations found. Woof!
4d5ac66

@sarken sarken added Awaiting review Priority: Critical labels Sep 8, 2017

@elzj elzj merged commit 881dec8 into otwcode:master Sep 8, 2017
3 of 4 checks passed

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer No new issues
Details
codeclimate All good!
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment