Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5129: Fix issue with remember_me amnesia #3024
Conversation
| @@ -34,7 +35,7 @@ def create | ||
| if user.updated_at > 1.week.ago | ||
| # we sent out a generated password and they're using it | ||
| # log them in | ||
| - @current_user = UserSession.create(user, params[:remember_me]).record | ||
| + @current_user = UserSession.create(user, user_sesssion_params['remember_me']).record |
sarken
Sep 1, 2017
Owner
Travis helpfully pointed out there's an extra s in the middle of sessions here -- can you also change to double quotes when you fix that? Then we should be ready to go
sarken
merged commit 0c213f2
into
otwcode:master
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
elzj commentedSep 1, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5129
Purpose
Fixes issue with remember_me setting on login not being respected
Testing
Log in, click remember me, close browser, reopen - you should still be logged in