/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5139 Tell Hound to prefer template tokens #3020

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Reviewers

@sarken sarken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@redsummernight @sarken
@redsummernight
Contributor

redsummernight commented Aug 30, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5139

Purpose

Suppress Hound's suggestions similar to this:

Prefer annotated tokens (like %s) over template tokens (like %{foo}).

Testing

None. I tried it locally using RuboCop, with/without the new setting.

rvm use 2.3.0
gem install rubocop
rubocop -c config/.rubocop.yml app/controllers/admin/admin_invitations_controller.rb
@redsummernight
AO3-5139 Tell Hound to prefer template tokens

All checks have passed

4 successful checks
Scrutinizer — No new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
6181fea

@sarken sarken merged commit 2919a1b into otwcode:master Aug 30, 2017
4 checks passed

4 checks passed

Scrutinizer No new issues
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@redsummernight redsummernight deleted the redsummernight:AO3-5139-hound-fmt-str-token branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment