Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5137: Add catchall route to fix autocomplete errors #3019

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
Owner

elzj commented Aug 30, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5137

Purpose

Fixes routing errors for a variety of autocomplete fields, including admin posts, skins, and collection filtering

Testing

All the autocompletes should work now

- get '/autocomplete/associated_tags' => 'autocomplete#associated_tags'
+ # TODO: rewrite the autocomplete controller to deal with the fact that
+ # there are fifty different actions going on in there
+ get '/autocomplete/:action' => 'autocomplete#%{action}'
@houndci-bot

houndci-bot Aug 30, 2017

Prefer annotated tokens (like %s) over template tokens (like %{foo}).

sarken approved these changes Aug 30, 2017

Approved pending Travis!

@sarken sarken merged commit f7e6672 into otwcode:master Aug 30, 2017

4 checks passed

Scrutinizer No new issues
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound 1 violation found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment