/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-3958 Test unescaped HTML in title field when editing work/series #3018

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Reviewers

@sarken sarken

Assignees
No one assigned
Labels
Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
2 participants
@redsummernight @sarken
@redsummernight
Contributor

redsummernight commented Aug 30, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-3958

Purpose

AO3-3958 was already fixed at some point, I'm just adding tests.

Testing

See issue.
@redsummernight
AO3-3958 Test unescaped HTML in title field when editing work/series

All checks have passed

4 successful checks
Scrutinizer — No new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
82f7ffc

@sarken sarken added the Awaiting review label Aug 30, 2017

@sarken

sarken approved these changes Aug 30, 2017
View changes

Looks good! I was going to suggest using the And I edit the work "Title" step, but if I recall correctly, that doesn't work with characters like <. Is that correct?

@sarken sarken added Reviewed: Ready to Merge and removed Awaiting review labels Aug 30, 2017

@redsummernight
Contributor

redsummernight commented Aug 30, 2017

Yeah, the title is stored in the escaped form (&lt;) so using Work.find_by(title: "<") would miss it, and I don't want to make the steps more complex.

@sarken sarken merged commit 452ddb5 into otwcode:master Aug 30, 2017
4 checks passed

4 checks passed

Scrutinizer No new issues
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@redsummernight redsummernight deleted the redsummernight:AO3-3958-title-edit-test branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment