Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5119 Rails BOT Don't send deleted sign-up email #3012
Conversation
sarken
added
Awaiting review
Priority: Broken on Test (High)
labels
Aug 26, 2017
ariana-paris
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Aug 27, 2017
ariana-paris
merged commit e2165df
into
otwcode:master
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sarken commentedAug 26, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5119
Purpose
The Rails upgrade fixed a bug that was preventing us from sending an email when challenge sign-ups were deleted. Alas, this email had no text and no formatting, just attachments, so it's not a good email to be sending... and no one missed it, since it has been broken for years. Ergo, this removes the code for sending that email, bringing the behavior in line with what's currently on production.
(I didn't run our massive pile of challenge tests locally, so it would not surprise me if Travis fails and I need to update some tests.)
Testing
Refer to JIRA