/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5108 Rails BOT: Fix params issue with inbox filtering #3006

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Reviewers

@sarken sarken

Assignees
No one assigned
Labels
Priority: Broken on Test (High) Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
2 participants
@elzj @sarken
@elzj
Owner

elzj commented Aug 24, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5108

Purpose

Fixes strong parameter related issue causing errors on inbox filtering.

Testing

Inboxes should be filterable again.
@elzj
AO3-5108: Fix params issue with inbox filtering

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
Scrutinizer — 1 updated code elements
Details
hound — No violations found. Woof!
a41d7e9

@elzj elzj added Priority: Broken on Test (High) Awaiting review labels Aug 24, 2017

@sarken

sarken requested changes Aug 24, 2017
View changes

It looks like these are real test failures in the specs.

@sarken sarken added Reviewed: Needs Coder Action and removed Awaiting review labels Aug 24, 2017

@elzj
AO3-5108: Update specs to reflect variable changes

All checks have passed

3 successful checks
Scrutinizer — 1 updated code elements
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
bd78721
@sarken

sarken approved these changes Aug 24, 2017
View changes

Looks good! Will merge when Travis is done.

@sarken sarken added Reviewed: Ready to Merge and removed Reviewed: Needs Coder Action labels Aug 24, 2017

@sarken sarken changed the title from AO3-5108: Fix params issue with inbox filtering to AO3-5108 Rails BOT: Fix params issue with inbox filtering Aug 24, 2017

@sarken sarken merged commit 16084bc into otwcode:master Aug 24, 2017
3 checks passed

3 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment