/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5109 Rails BOT: Don't auto disable submit buttons after they're pressed #3004

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Reviewers

@elzj elzj

Assignees
No one assigned
Labels
Awaiting review Priority: Broken on Test (High)
Projects
None yet
Milestone
No milestone
2 participants
@sarken @elzj
@sarken
Owner

sarken commented Aug 24, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5109

Purpose

As a result of the Rails upgrade, all submit buttons were getting disabled after they were pressed, which caused problems like not being able to preview a work after correcting a validation error resulting from a missing title.

Testing

Refer to JIRA

References

https://stackoverflow.com/a/44025628
http://edgeguides.rubyonrails.org/configuring.html#configuring-action-view
@sarken
AO3-5109 Don't automatically disable all submit buttons after they're… 
… pressed

All checks have passed

3 successful checks
Scrutinizer — No new issues
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
d3d61f6

@sarken sarken added Awaiting review Priority: Broken on Test (High) labels Aug 24, 2017

@elzj

elzj approved these changes Aug 24, 2017
View changes

@elzj elzj merged commit bde1c62 into otwcode:master Aug 24, 2017
3 checks passed

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment