Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
AO3-5082 Intermittent test failure when removing self as co-author of series or work #2973
Conversation
sarken
added some commits
Jul 25, 2017
sarken
added
Awaiting review
Reviewed: Needs Coder Action
and removed
Awaiting review
labels
Jul 25, 2017
sarken
closed this
Jul 25, 2017
sarken
added
Awaiting review
and removed
Reviewed: Needs Coder Action
labels
Jul 25, 2017
sarken
reopened this
Jul 25, 2017
scottsds
approved these changes
Sep 25, 2017
These test changes look good, reference is made to AO3-5083 so we know to come back to it ...some day...
scottsds
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Sep 25, 2017
sarken
merged commit 46195a9
into
otwcode:master
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sarken commentedJul 25, 2017
•
Edited 1 time
-
sarken
Jul 25, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5082
Purpose
Adds a 1-second delay to tests for removing yourself as the co-author of a work or series, since the byline cache needs time to update. Comment out the test for removing yourself as the co-author of a series, since it turns out that's an actual bug. Refactor slightly to use the pretty step definition for checking the author(s) displayed on a work or series page.
Testing
No manual testing required, but keep an eye on Codeship and Travis to make sure this has improved the situation and we see fewer failures in other_b/series.feature and works/work_edit.feature.