Ability to configure custom date formats #40

Merged
merged 1 commit into from Jan 18, 2017

Projects

None yet

2 participants

@adrianmo
Contributor
  • Fixes #37
  • Default date format set to "January 2, 2006"
@adrianmo adrianmo Fixes ability to configure custom date formats
Fixes #37
Default date format set to "January 2, 2006"
c633e08
@adrianmo adrianmo added the bug label Jan 18, 2017
@adrianmo adrianmo self-assigned this Jan 18, 2017
@adrianmo adrianmo requested a review from ryanfox1985 Jan 18, 2017
@@ -37,7 +37,10 @@ paginate = 10
about_us = "<p>Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas.</p>"
copyright = "Copyright (c) 2015 - 2016, YourCompany; all rights reserved."
- date_format = "2006-01-02"
@ryanfox1985
ryanfox1985 Jan 18, 2017 • edited Member

Hi @adrianmo, maybe in the templates we need to prevent if the user forget the date_format parameter in the configuration file or the format is wrong?

@adrianmo
adrianmo Jan 18, 2017 Contributor

@ryanfox1985 in the config file it's already stated that the date_format has to be a Go's compatible time format, and an example is already given. So I don't see the need to add more complexity and check the date format in the templates.

@adrianmo adrianmo merged commit 5098170 into master Jan 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adrianmo adrianmo deleted the fix-date-format branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment