Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[WIP] Add Jetpack CSS support for Code Editor control in core patch #7794
+62
−9
Conversation
westonruter
requested a review
from
georgestephanis
as a
code owner
Sep 16, 2017
jeherve
added
Custom CSS
[Status] In Progress
[Type] Enhancement
labels
Sep 20, 2017
|
The dependency xwp/wordpress-develop#257 has been merged into |
jeherve
added
[Pri] High
[Status] Needs Review
and removed
[Status] In Progress
labels
Sep 22, 2017
georgestephanis
added
the
[Pri] BLOCKER
label
Oct 4, 2017
georgestephanis
added this to the 5.5 milestone
Oct 4, 2017
georgestephanis
referenced this pull request
Oct 20, 2017
Merged
Pr/7794 Redux -- Core 4.9 / Custom CSS #8028
georgestephanis
self-assigned this
Oct 20, 2017
|
Closing in favour of #8028. (The commit here is included in the other PR) |
oskosk
closed this
Oct 23, 2017
oskosk
removed
the
[Status] Needs Review
label
Oct 23, 2017
added a commit
that referenced
this pull request
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
westonruter commentedSep 16, 2017
I wanted to give you a jump start on updating Custom CSS in Jetpack with the new code editor APIs in 4.9-alpha. This is just an initial integration which fixes the JS error that was caused by Jetpack and core conflicting. I'm sure there is additional integration work needed, specifically in the realm of switching between CSS, LESS, and SCSS. But I hope this is helpful for you to get started and also to evaluate the proposed core changes in Trac #41897 which makes the Custom CSS control in the Customizer actually extensible (please apply that core patch or checkout the branch to test). Any findings from the Jetpack integration here will inform what changes need to be made in that core patch.
So I hand this over to the Jetpack team to amend as needed.
Depends on xwp/wordpress-develop#257 which resolves https://core.trac.wordpress.org/ticket/41897
Fixes #7776.