Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[WIP] Add Jetpack CSS support for Code Editor control in core patch #7794

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

westonruter commented Sep 16, 2017

I wanted to give you a jump start on updating Custom CSS in Jetpack with the new code editor APIs in 4.9-alpha. This is just an initial integration which fixes the JS error that was caused by Jetpack and core conflicting. I'm sure there is additional integration work needed, specifically in the realm of switching between CSS, LESS, and SCSS. But I hope this is helpful for you to get started and also to evaluate the proposed core changes in Trac #41897 which makes the Custom CSS control in the Customizer actually extensible (please apply that core patch or checkout the branch to test). Any findings from the Jetpack integration here will inform what changes need to be made in that core patch.

So I hand this over to the Jetpack team to amend as needed.

Depends on xwp/wordpress-develop#257 which resolves https://core.trac.wordpress.org/ticket/41897

Fixes #7776.

@westonruter westonruter requested a review from georgestephanis as a code owner Sep 16, 2017

Contributor

westonruter commented Sep 21, 2017

The dependency xwp/wordpress-develop#257 has been merged into trunk as r41558, and so wpcore#41897 is now resolved and there are no other dependencies for testing this PR, other than to be on trunk.

@georgestephanis georgestephanis added this to the 5.5 milestone Oct 4, 2017

@georgestephanis georgestephanis self-assigned this Oct 20, 2017

Contributor

oskosk commented Oct 23, 2017

Closing in favour of #8028. (The commit here is included in the other PR)

@oskosk oskosk closed this Oct 23, 2017

jeherve added a commit that referenced this pull request Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment