WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 5 days ago

#45433 closed defect (bug) (fixed)

Twenty Eleven: Button blocks don't apply custom colours

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots commit fixed-5.0
Focuses: Cc:

Description

The selectors used for Twenty Eleven's button blocks are too specific, the styles for the editor custom colours don't override them on the front-end.

Attachments (4)

twenty-eleven-custom-colors-editor.png (29.3 KB) - added by laurelfulford 4 weeks ago.
Twenty Eleven - custom colours correct in editor
twenty-eleven-custom-colors-front-end-before.png (38.8 KB) - added by laurelfulford 4 weeks ago.
Twenty Eleven - custom colours on front end - before
45433.patch (911 bytes) - added by laurelfulford 4 weeks ago.
twenty-eleven-custom-colors-front-end-after.png (39.7 KB) - added by laurelfulford 4 weeks ago.
Twenty Eleven - custom colours on front end - after

Download all attachments as: .zip

Change History (13)

@laurelfulford
4 weeks ago

Twenty Eleven - custom colours correct in editor

@laurelfulford
4 weeks ago

Twenty Eleven - custom colours on front end - before

@laurelfulford
4 weeks ago

@laurelfulford
4 weeks ago

Twenty Eleven - custom colours on front end - after

#1 @laurelfulford
4 weeks ago

45433.patch makes the selectors adding the text and button colours to the buttons less specific, so the custom colour selectors can override them.

#2 @davidakennedy
4 weeks ago

  • Keywords commit added; needs-testing removed

Hey @laurelfulford! This looks good to go after some testing.

#3 @laurelfulford
4 weeks ago

  • Milestone changed from 5.0 to 5.0.1

#4 @Joen
3 weeks ago

Patch looks good 👍 👍! Nicely done.

#5 @pento
11 days ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @laurelfulford
9 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44191:

Twenty Eleven: Fix button block custom colors on front end.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Fixes #45433.

#7 @desrosj
9 days ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#8 @SergeyBiryukov
7 days ago

  • Keywords changed from has-patch, has-screenshots, commit, fixed-5.0 to has-patch has-screenshots commit fixed-5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @desrosj
5 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44301:

Twenty Eleven: Correct font-size and button issues.

Update a mistake in Twenty Eleven's block editor styles that erroneously sets the font-size to 300, when it should set the font-weight to 300. This was causing browsers in quirks mode to make the editor font size very large.

Also, simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Props laurelfulford.

Merges [44190] and [44191] to trunk.

Fixes #45421, #45433.

Note: See TracTickets for help on using tickets.