WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 5 days ago

#45428 closed defect (bug) (fixed)

Twenty Fifteen: Button blocks don't apply custom colours

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots commit fixed-5.0
Focuses: Cc:

Description

The selectors used for Twenty Fifteen's button blocks are too specific, the styles for the editor custom colours don't override them on the front-end.

Attachments (4)

twenty-fifteen-custom-colors-editor.png (63.7 KB) - added by laurelfulford 4 weeks ago.
Twenty Fifteen - custom colours applied in editor
twenty-fifteen-custom-colors-front-end-before.png (57.5 KB) - added by laurelfulford 4 weeks ago.
Twenty Fifteen - custom colours on front end, before
45428.patch (935 bytes) - added by laurelfulford 4 weeks ago.
twenty-fifteen-custom-colors-front-end-after.png (58.8 KB) - added by laurelfulford 4 weeks ago.
Twenty Fifteen - custom colours on front end, after

Download all attachments as: .zip

Change History (13)

@laurelfulford
4 weeks ago

Twenty Fifteen - custom colours applied in editor

@laurelfulford
4 weeks ago

Twenty Fifteen - custom colours on front end, before

@laurelfulford
4 weeks ago

@laurelfulford
4 weeks ago

Twenty Fifteen - custom colours on front end, after

#1 @laurelfulford
4 weeks ago

45428.patch moves the colour and background colours on the button to a slightly less specific selector, so the custom colours can override them.

#2 @davidakennedy
4 weeks ago

  • Keywords commit added; needs-testing removed

Hi @laurelfulford! I tested this one, and it's good to go.

#3 @laurelfulford
4 weeks ago

  • Milestone changed from 5.0 to 5.0.1

#4 @Joen
3 weeks ago

Patch looks good 👍 👍! 🚀

#5 @pento
11 days ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @laurelfulford
9 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44198:

Twenty Fifteen: Fix button block custom colors on front end.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Fixes #45428.

#7 @desrosj
9 days ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#8 @SergeyBiryukov
7 days ago

  • Keywords changed from has-patch, has-screenshots, commit, fixed-5.0 to has-patch has-screenshots commit fixed-5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @desrosj
5 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44306:

Bundled Themes: Fix button block custom colors on front end.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

This fix is applied to Twenty Sixteen, Twenty Fifteen and Twenty Fourteen.

Props laurelfulford.

Merges [44197-44198] and [44200] into trunk.

Fixes #45428, #45429.

Note: See TracTickets for help on using tickets.