WordPress.org

Make WordPress Core

Opened 5 days ago

Last modified 5 days ago

#42586 new defect (bug)

Search function in Editor now broken with update to 4.9

Reported by: wpress2010 Owned by:
Milestone: 4.9.1 Priority: high
Severity: major Version: 4.9
Component: General Keywords: needs-patch
Focuses: administration Cc:

Description

When in the Appearance/Editor, f'rinstance, when editing a child theme's CSS file, the Ctrl-F (Search) no longer works. SOMETIMES it will find a string IF that string is on the VISIBLE portion of the screen. It will NOT find that string in the file if the string is NOT visible.

Sometimes it will not find the string at all - visible or not.

A serious impeiment to the Editor!

Change History (4)

#1 @johnbillion
5 days ago

  • Component changed from Editor to General
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9.1
  • Priority changed from normal to high
  • Severity changed from normal to major

I just noticed this too. The search (which overrides the built-in browser search) is unusable. It doesn't allow for moving between instances of search results.

#2 @johnbillion
5 days ago

Actually, navigating between results can be done with cmd+g but there's no visual indication of this, like there is with the browser's built-in search.

#3 @melchoyce
5 days ago

Are you getting any console errors? I'm able to search using the code editor's built in search without issue (though there isn't a way to move to the next result or back, but I don't think it ever had that?)

#4 @wpress2010
5 days ago

I am not sure what you are referring to here. The "built-in editor" apparently is only called when you click on the link in the stylesheet file when in the Editor - a new message above the editing area that says,

"Did you know?

There’s no need to change your CSS here — you can edit and live preview CSS changes in the built-in CSS editor."

Foolish message, as I AM editing the child theme's CSS file! This new "feature" is just some kind of "dumbing down" of the admin functions, IMHO.

Is there a way to invoke this "built-in CSS editor" in the actual CSS file? I personally think that making styling changes via the theme's "Additional CSS" Customize tab is BAD practice. That's what a child theme is for!

Note: See TracTickets for help on using tickets.