WordPress.org

Make WordPress Core

Opened 10 days ago

Last modified 4 days ago

#42214 assigned task (blessed)

Code Editors: Minor style improvements

Reported by: melchoyce Owned by: melchoyce
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: General Keywords: needs-patch
Focuses: ui Cc:

Description

The code editors could use some minor design tweaks. See attached mockup, where I've...:

  • Added a 1px solid #ddd background around the entire editor
  • Increased the width of the the file contents to 100%
  • Removed any margin-left on the file list
  • Added a background (#f7f7f7, to match the line numbers background) behind the file list
  • Also added a border-left of 1px solid #ddd to the file list
  • Increased the padding inside the file list to 5px 5px 8px
  • Made the current file styling full-width inside the file list
  • Removed the border-bottom on the "Theme/Plugin Files" header

Anyone want to take a stab at patching this?

Attachments (3)

file-list.png (844.0 KB) - added by melchoyce 10 days ago.
42214.diff (1.7 KB) - added by melchoyce 10 days ago.
42214.2.diff (1.9 KB) - added by helen 7 days ago.

Download all attachments as: .zip

Change History (9)

@melchoyce
10 days ago

@melchoyce
10 days ago

#1 @melchoyce
10 days ago

42214.diff is a first stab at making some design improvements.

It needs a review, and could still use some additional padding inside of #templateside. This is also ridiculously minor, but it'd be great to get the current file styling when the first file is selected to be flush with the top of the list, so there's no gap.

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


7 days ago

@helen
7 days ago

#3 @helen
7 days ago

In 41882:

Code Editors: Minor style improvements.

props melchoyce.
see #42214.

#4 @helen
7 days ago

The focus styling is not really awesome and this could use testing/tweaking on touch devices/small screens, so leaving this open for now.

#5 @westonruter
5 days ago

  • Owner set to melchoyce
  • Status changed from new to assigned

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


4 days ago

Note: See TracTickets for help on using tickets.