WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 10 days ago

#40103 new defect (bug)

Twenty Seventeen: Blockquotes aligned right are not behaving as expected

Reported by: laurelfulford Owned by:
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

When you align a blockquote to the right and have assigned sidebar widgets, Twenty Seventeen should be placing the blockquote fully in the right sidebar.

This currently isn’t working until you resize the browser window. There’s some JavaScript in the theme used to make sure the sidebar isn’t too long before moving over the blockquote - right not it looks like it's only firing on resize, but not on page load.

Here’s how a single post currently looks with an aligned right blockquote and a sidebar widget:

https://cldup.com/MudPXRobwl-3000x3000.png

When the browser is resized, the blockquote is moved to its correct location:

https://cldup.com/ygEYYBp6Bv-3000x3000.png

Attachments (1)

40103.patch (593 bytes) - added by laurelfulford 22 months ago.
Add fix so also fires JavaScript event that determines if blockquote can be moved on page load.

Download all attachments as: .zip

Change History (7)

@laurelfulford
22 months ago

Add fix so also fires JavaScript event that determines if blockquote can be moved on page load.

#1 @laurelfulford
22 months ago

  • Keywords has-patch added

#2 @davidakennedy
11 months ago

  • Milestone changed from Awaiting Review to 5.0

#3 @laurelfulford
5 months ago

  • Keywords needs-testing added

#4 @pento
8 weeks ago

  • Milestone changed from 5.0 to 5.0.1

#5 @laurelfulford
3 weeks ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @laurelfulford
10 days ago

  • Milestone changed from 5.0.2 to 5.1
Note: See TracTickets for help on using tickets.