Opened 11 years ago
Last modified 3 weeks ago
#2833 reopened defect (bug)
wpautop breaks style and script tags
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 4.8.1 | Priority: | low |
| Severity: | normal | Version: | 2.0.3 |
| Component: | Formatting | Keywords: | wpautop has-patch dev-feedback |
| Focuses: | Cc: |
Description
When I create a post in which I want to include Javascript or some styles, WordPress 'breaks'when showing those posts, because all newlines in the SCRIPT and STYLE tag are converted into BR tags.
Example:
<style type="text/css>
.matt { color: #FFFFFF; }
</style>
Becomes:
<style type="text/css><br />
.matt { color: #FFFFFF; }<br />
</style><br />
And:
<script type="text/javascript"><!-- google_ad_client = "xxxxxxxx"; google_ad_width = 120; google_ad_height = 60; google_ad_format = "120x60_as_rimg"; google_cpa_choice = "CAAQ2eOZzgEaCD4zuVkdzt_CKI-293M"; //--></script>
Becomes
<script type="text/javascript"><!--<br /> google_ad_client = "xxxxxxxx";<br /> google_ad_width = 120;<br /> google_ad_height = 60;<br /> google_ad_format = "120x60_as_rimg";<br /> google_cpa_choice = "CAAQ2eOZzgEaCD4zuVkdzt_CKI-293M";<br /> //--></script><br />
This happens because wpautop adds those BR tags to the post. (As it should, just not within STYLE or SCRIPT tags.)
I've made a (temporary?) workaround for this by creating a pre and post event for wpautop, which substitute the necessary newlines by a temporary value in the pre event and placing them back in the post event. Although I think this should be incorporated in wpautop itself.
See also: http://wordpress.org/support/topic/76433 and http://wordpress.org/support/topic/76297
While searching trac I also found ticket #2346, which is about the same problem, but which was for 2.0 and self-closed by the submitter?
P.S. I have TinyMCE turned of.
Attachments (4)
Change History (33)
#2
@skeltoac
11 years ago
Just looking at your code... the brackets on line 74 look like a mistake to me. As is, it will also match tags like p, pre, tr, li. Once you've dropped the brackets it should be fine.
#5
@reneade
8 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
In 2.7 JavaScript is still damaged by wpautop if it contains empty lines:
test
<script language="javascript">
alert( 'test' );
</script>
test
will be changed to
<p>test</p> <p><script language="javascript"></p> <p> alert( 'test' );</p> <p></script></p> <p>test</p>
#6
@reneade
8 years ago
It seems that there is already a fix within this plugin that maybe could be used: http://www.automateyourbusiness.com/updates/2007/07/18/javascript-in-wordpress-posts/
#7
@Denis-de-Bernardy
8 years ago
- Milestone changed from 2.1 to 2.8
confirmed in wp 2.8. and switching back and forth with tinymce breaks it to:
<p><script language="javascript"><!-- alert( 'test' ); // --></script></p>
#8
@ShaneF
8 years ago
- Cc ShaneF added
- Keywords bg bg needs-patch needs-testing added; bg|has-patch bg|needs-testing removed
After several attempts it seems this has yet to be fixed. The current patch was commit a while back but it still doesn't resolve spaced style or javascript code.
#11
@Denis-de-Bernardy
8 years ago
I've had a similar issue on one of my plugins, at one point. (As in, things got processed when they really shouldn't.)
To fix, I went something like:
- Replace entire area with a unique place holder
- Process everything
- Replace the unique place holder with its original content
In case it prompts ideas... It would then also fix the SVG problem: #9437
#12
@Denis-de-Bernardy
8 years ago
- Keywords wpautop break script style br bg bg needs-testing removed
- Milestone changed from 2.8 to Future Release
#14
@Denis-de-Bernardy
8 years ago
- Milestone changed from Future Release to 2.9
#15
@hakre
8 years ago
Please close as wontfix. Fixing things will break other things and vice-versa. I do not know a single seriuos developer that wants to touch this.
Best would be to get a decription first what must (not)/should (not)/can (not) be done by wpautop. Then testcases must be written and the the function must be re-worked.
#16
@azaozz
8 years ago
- Keywords needs-unit-tests added
- Milestone changed from 2.9 to Future Release
#17
@wonderboymusic
5 years ago
Here is what presently happens in trunk:
<p>test</p> <p><script type="text/javascript" language="javascript">// <![CDATA[ alert( 'test' ); // ]]></script></p> <p>test</p>
So seems like the only remaining issue for *this ticket* is incorrectly <p>'ing the inline script
#19
@cmmarslender
3 years ago
- Keywords has-patch added; needs-patch needs-unit-tests removed
Added a patch that addresses the issues with the contents of 'script' tags being altered. Uses the same method that was used to prevent the contents of 'pre' tags (removing the actual contents of the tag, and replacing with a placeholder). Abstracted the code that replaces the tags into its own helper function, so that there isn't a ton of nearly-identical code inside of wpautop()
Also added a unit test to check the 'script' case - based on the unit tests for 'pre' case.
Tested with groups 2833 (my tests) and 19855 (existing tests for 'pre' tags) and they both passed.
This could conceivably be used in the future for other things that should not have the inner contents modified, such as 'style' tags - maybe others?
#20
@adamsilverstein
3 years ago
- Keywords dev-feedback added
This ticket was mentioned in IRC in #wordpress-dev by adamsilverstein. View the logs.
3 years ago
#22
@miqrogroove
22 months ago
As of 4.2.3, we are now avoiding newlines inside of HTML comments and CDATA comments. There are a couple more bugs to work out, but I expect that to be fully working by 4.3.1.
I haven't had time yet to fully review the patch.
#23
@pento
9 months ago
2833.3.diff is an experiment with this, it works by duplicating wp_replace_in_html_tags(), and make it work on tag content, too.
This is could be a lot better.
Also, needs more unit tests.
#24
@adamsilverstein
7 weeks ago
Added some tests for the cases given here on 2691 which solves some of the remaining issues raised here.
This ticket was mentioned in Slack in #core by adamsilverstein. View the logs.
3 weeks ago
This ticket was mentioned in Slack in #core by adamsilverstein. View the logs.
3 weeks ago
#27
@westonruter
3 weeks ago
- Milestone changed from Future Release to 4.8.1
Milestoning for 4.8.1 since this is going to be a particular problem for Text widgets where users paste in scripts that may have double line breaks.
This change to wpautop should fix the aforementioned behaviour.
I've tested it on my box, but would like to get some feedback.