Add an action hook at the end of wpmu_delete_blog

[pauldewouters]

I have the need of an additional hook in the wpmu_delete_blog function in wp-admin/includes/ms.php.

I'm maintaining a list of active blogs in a DB option which also has extra data associated. I update this list on 2 hooks currently: wpmu_new_blog and delete_blog

Unfortunately, the delete_blog occurs before the actual blog deletion, so at that point, an SQL query will return that blog too.

If there were a hook after the actual deletion, I could retrieve the list of active blogs.

25584.diff​ is slightly different from the original patch. I think deleted_site aligns with the naming of some other hooks in core. Docs for the hook have also been updated to reflect the proper version for @since.

Worth noting that the parent function is named wpmu_delete_blog, and this hook would be preceded by a delete_blog hook. So perhaps in the name of consistency we should go with deleted_blog vs deleted_site.

If at some time in the future the parent function gets renamed to say, wp_delete_site, I'd imagine the hooks would remain in the name of posterity and back-compat. I think either situation (renaming or not renaming the function), I'd prefer the hooks match. That's just me.

I'd tend to agree with keeping the hooks the same style.

25584.2.diff​ is a refresh for 3.9, goes with deleted_blog as the filter.

+1 for 25584.2.diff​.

thanks for the improvements

25584.2.diff​ still applies cleanly. Adds deleted_blog filter with docs.

The hook docs in 25584.2.diff​ look great. Let's do this thing.

This filter is inside a if ( $drop ) conditional which means it would only be fired when data is actually deleted.

I'll be honest, I don't see much of a purpose for this hook. The existing delete_blog action is enough, even though it is on pre-transaction. If you're trying to query only active blogs, simply exclude the blog for which the hook has fired. While we would generally provide and benefit from a post-transaction hook, I'd hesitate to bother adding one until we re-do this function at some point down the line (with better terminology and less hackery).

+1 for this request.

I also just ran into a need for this.

Core already has deleted_post and deleted_user, so the proposed deleted_blog action makes sense.

I'm -1 on naming it deleted_site for the reasons @DrewAPicture stated.

Move action outside of $drop check and pass $drop as a parameter to match delete_blog usage

25584.3.diff​ looks good. I think it makes sense adding this to help with other cleanup related operations. If we ever redo this function, it will likely be very different and have different actions.

In 40351:

Multisite: Add deleted_blog action after site has been deleted.

Props pauldewouters, johnjamesjacoby.
Fixes #25584.