Steps to reconnect to a presentation assume there's already a PresentationConnection #366
Comments
mfoltzgoogle
referenced
this issue
Nov 22, 2016
Merged
Clarify identities of PresentationConnection objects in reconnect() steps #376
|
On closer reading it's not a problem with the steps, it's just hard to keep track of the different objects. Tried to improve this with the PR. |
mfoltzgoogle
closed this
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mfoltzgoogle commentedNov 12, 2016
The steps to reconnect to a presentation (6.3.3., step 8) talk about using an existing
PresentationConnectionobject to construct a newPresentationConnection. But if the page already has one it's not clear why we would need to construct a new one. It would be clearer to refer instead to the set of controlled presentations when constructing a newPresentationConnection.