/bootstrap

Use @carousel-control-font-size for in min-width sm #16975

Merged
merged 1 commit into from Nov 13, 2015

Labels

css v3

Milestone

  v3.3.6

Assignees

No one assigned

3 participants

@kkirsche @mdo @cvrebert
@kkirsche
kkirsche commented Aug 12, 2015

Fix #16973

As 30px was hard coded for the following attribute values: width, height, and font-size, I have used the same pixel formula for each of these three as the @carousel-control-width is a percent value not a pixel value in variables.less

If margin-top should be calculated we can also do that with a (@carousel-control-font-size * -0.75)

@kkirsche kkirsche Use @carousel-control-font-size for in min-width sm 
Fix #16973

As 30px was hard coded for the following attribute values: `width`, `height`, and `font-size`, I have used the same pixel formula for each of these three as the `@carousel-control-width` is a percent value not a pixel value in variables.less
4f09bbc
@cvrebert cvrebert added the css label Aug 12, 2015
@mdo
Bootstrap member
mdo commented Nov 9, 2015

If margin-top should be calculated we can also do that with a (@carousel-control-font-size * -0.75)

Yup, it should.

@mdo mdo added this to the v3.3.6 milestone Nov 9, 2015
@cvrebert cvrebert added the v3 label Nov 9, 2015
@mdo mdo merged commit 332ed55 into twbs:master Nov 13, 2015
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@mdo mdo referenced this pull request Nov 13, 2015
Closed

v3.3.6 ship list #16644

@mdo mdo added a commit that referenced this pull request Nov 13, 2015
@mdo mdo Follow up to #16975 1565c11
@mdo
Bootstrap member
mdo commented Nov 13, 2015

Took care of the margin changes in 1565c11.

@kkirsche kkirsche referenced this pull request in elastic/kibana Feb 21, 2016
Merged

Update Bootstrap to 3.3.6 #6294

@krissihall krissihall pushed a commit to krissihall/bootstrap that referenced this pull request Feb 24, 2016
Hall, Kristina Merge tag 'v3.3.6' of https://github.com/twbs/bootstrap into smcrossover 
* tag 'v3.3.6' of https://github.com/twbs/bootstrap: (356 commits)
  prep release
  grunt after version bump
  bump version
  grunt
  Updating "Reporting upstream browser bugs" for IE
  Docs: Add missing `tabindex="-1"` & `role="dialog"` to some `.modal`s
  Ensure proper z-indexing in input-groups
  Fix IE9 clickthru of carousel controls
  that @cvrebert lifestyle
  fixes #17003
  [v3] Use border-radius mixin in button-groups.less
  Follow up to #16975
  Run `grunt`.
  Update devDependencies.
  Update verb tenses to proper tense for feature deprecations
  Port 33103c0 to v3
  Port 6f14f02 to v3
  Add http://wkbug.com/150715 to Wall of Browser Bugs
  Add docs regarding .progress, inline style attrs, and CSP; closes #17785
  Run `grunt.
  ...
 5d22f6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment