Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5254: Upgrade to Elasticsearch 6 #3183
Conversation
WendyBeth
and others
added some commits
Oct 20, 2017
| @@ -36,19 +36,19 @@ | ||
| it "should not return bookmarks of hidden objects" do | ||
| q = BookmarkQuery.new | ||
| - expect(q.filters).to include({has_parent:{type: 'bookmarkable', filter:{term: { hidden_by_admin: 'false' }}}}) | ||
| + expect(q.filters).to include({has_parent:{parent_type: 'bookmarkable', query:{term: { hidden_by_admin: 'false' }}}}) |
houndci-bot
Nov 27, 2017
Space inside { missing.
Redundant curly braces around a hash parameter.
Space missing after colon.
Space inside } missing.
| end | ||
| it "should not return restricted bookmarked works by default" do | ||
| User.current_user = nil | ||
| q = BookmarkQuery.new | ||
| - expect(q.filters).to include({has_parent:{type: 'bookmarkable', filter:{term: {restricted: 'false'}}}}) | ||
| + expect(q.filters).to include({has_parent:{parent_type: 'bookmarkable', query:{term: {restricted: 'false'}}}}) |
houndci-bot
Nov 27, 2017
Space inside { missing.
Redundant curly braces around a hash parameter.
Space missing after colon.
Space inside } missing.
| end | ||
| it "should only return restricted bookmarked works when a user is logged in" do | ||
| User.current_user = User.new | ||
| q = BookmarkQuery.new | ||
| - expect(q.filters).not_to include({has_parent:{type: 'bookmarkable', filter:{term: {restricted: 'false'}}}}) | ||
| + expect(q.filters).not_to include({has_parent:{parent_type: 'bookmarkable', query:{term: {restricted: 'false'}}}}) |
houndci-bot
Nov 27, 2017
Space inside { missing.
Redundant curly braces around a hash parameter.
Space missing after colon.
Space inside } missing.
| @@ -63,7 +63,7 @@ | ||
| it "should allow you to filter for complete works" do | ||
| q = BookmarkQuery.new(complete: true) | ||
| - expect(q.filters).to include({has_parent:{type: 'bookmarkable', filter:{term: {complete: 'true'}}}}) | ||
| + expect(q.filters).to include({has_parent:{parent_type: 'bookmarkable', query:{term: {complete: 'true'}}}}) |
houndci-bot
Nov 27, 2017
Space inside { missing.
Redundant curly braces around a hash parameter.
Space missing after colon.
Space inside } missing.
| @@ -115,7 +115,7 @@ | ||
| it "should allow you to filter for bookmarks by language" do | ||
| q = BookmarkQuery.new(language_id: 1) | ||
| - expect(q.filters).to include({has_parent:{type: 'bookmarkable', filter:{term: {language_id: 1}}}}) | ||
| + expect(q.filters).to include({has_parent:{parent_type: 'bookmarkable', query:{term: {language_id: 1}}}}) |
houndci-bot
Nov 27, 2017
Space inside { missing.
Redundant curly braces around a hash parameter.
Space missing after colon.
Space inside } missing.
elzj commentedNov 27, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5254
Purpose
Upgrade to Elasticsearch 6
Testing
See issue; upgrade changes mostly involve bookmarks