Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-4989 Returning to referer if deleting bookmark #3178
Conversation
hatal175
added some commits
Nov 20, 2017
sarken
added
the
Awaiting review
label
Nov 22, 2017
|
Can keep it like it originally was and just add the page parameter to the path (i.e. |
|
You could delete a bookmark from the browse bookmarks pages and end up in
your bookmarks page. I thought that was also counter-intuitive so i added
the referer which solved this issue as well You think I overdid it?
…
|
|
Yeah, I think we can consider that behavior separately and focus on the problem described in the issue. |
|
Looking at the code again, I really don't think the optimal solution would be to add the page somehow... the deletion link is deep inside the rendering parts and has no idea where it is rendered, nor I think it should know. If this is not acceptable, I recommend closing this pull request and extending the requirements of this feature. |
hatal175 commentedNov 22, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-4989
Purpose
This makes it so you return to referer if you delete a bookmark unless you came from a page specifically editing or deleting it. I saw the pattern used in the comment controller but I'm not sure it it's the best way of implementing this.
Testing
Delete bookmark from all possible places. If page still exists (user bookmarks second page, recent bookmarks, etc.) then you should still be at that page.
Credit
Tal Hayon
Please use he.