/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5135 Fix removing collections from Edit Works page #3173

Open
wants to merge 1 commit into
from

Conversation

Reviewers

@sarken sarken

Assignees
No one assigned
Labels
Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
2 participants
@hatal175 @sarken
@hatal175
Contributor

hatal175 commented Nov 19, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5135

Purpose

This fixes the issue by adding the missing collections_to_remove parameter from work_params. I also added feature tests for both adding and removing collections in multiple_edit.

Testing

Either run the feature tests or follow the scenario depicted in the bug report.

Credit

Tal Hayon

Please use he.
@hatal175
AO3-5135 Add missing collections_to_remove parameter to work_params

All checks have passed

4 successful checks
Scrutinizer — 2 new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
0d58889

@sarken sarken added the Awaiting review label Nov 19, 2017

@sarken sarken changed the title from AO3-5135 Add missing collections_to_remove parameter to work_params to AO3-5135 Fix removing collections from Edit Works page Nov 20, 2017

@sarken sarken added Reviewed: Ready to Merge and removed Awaiting review labels Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment