/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-4205 Adding ip address when importing works without preview #3169

Open
wants to merge 3 commits into
from

Conversation

Reviewers

@houndci-bot houndci-bot

Assignees
No one assigned
Labels
Awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@hatal175 @houndci-bot @sarken
@hatal175
Contributor

hatal175 commented Nov 18, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-4205

Purpose

Adds IP address of importer when posting without preview.

Testing

I added feature tests for these cases but the described procedure in the bug should do.

Credit

Tal Hayon

Please use he.

hatal175 added some commits Nov 11, 2017

@hatal175
Add feature test for the issue

All checks have passed

4 successful checks
Scrutinizer — 12 new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
ceb5d14
@hatal175
AO3-4205 Setting work ip when importing works
ca2689d
@hatal175
AO3-4205 Fix import_from_urls

All checks have passed

4 successful checks
Scrutinizer — 11 new issues, 1 updated code elements
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — 1 violation found.
e28dd74
app/models/story_parser.rb
@@ -81,6 +81,11 @@ def import_from_urls(urls, options = {})
urls.each do |url|
begin
work = download_and_parse_story(url, options)
+
+ if work
@houndci-bot

houndci-bot Nov 18, 2017

Use safe navigation (&.) instead of checking if an object exists before calling the method.

@sarken sarken added the Awaiting review label Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment