/otwarchive

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-5019 Fix text overlap in related works section on downloads #3167

Open
wants to merge 2 commits into
from

Conversation

Reviewers

@redsummernight redsummernight

Assignees
No one assigned
Labels
Awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@tuff @redsummernight @sarken
@tuff
Contributor

tuff commented Nov 17, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-5019

Purpose

Fix overlapping text in related works section on downloads.

Testing

See issue. The new related works section should look like this:
image
@tuff
AO3-5019 Fix text overlap in related works section on downloads

All checks have passed

4 successful checks
Scrutinizer — No new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
fd0e170

@sarken sarken added the Awaiting review label Nov 17, 2017

app/views/downloads/_download_preface.html.erb
+ <li>
+ <%= ts(work.translation ? 'A translation of' : 'Inspired by') %>
+ <%= link_to work.parent.title.html_safe, work_url(work.parent) %>
+ <%= ts("by") %> <%= byline(work.parent) %>.
@redsummernight

redsummernight Nov 21, 2017

Contributor

Previously byline was called with the option only_path: false, is it why in the screenshot "testy" are not pseud links?

@tuff

tuff Nov 21, 2017

Contributor

I noticed that they were not links on the page either, and assumed that was normal!

I think, on my local instance, the works were not being picked up as AO3 works and so were external...and it's probably only normal for external works. I'll restore only_path, which I definitely removed in error.

@tuff
AO3-5019 (review) Restore only_path:false in related works bylines
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

All checks have passed

4 successful checks
Scrutinizer — No new issues
Details
codeclimate — All good!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
hound — No violations found. Woof!
5ba03e4
@redsummernight
Contributor

redsummernight commented Nov 22, 2017

Looks good, thanks! One last thing, I think it would be easier for future translators if your ts contains the entire context. So instead of having 2 ts pieces with the work link in between, we should do something like:

if work.translation
    string = "A translation of #{work} by #{author}"
else
    string = "Inspired by #{work} by #{author}"
end

I'd wait for someone more familiar with Rails i18n to weigh in before changing things, though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment