Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-4676 Extended invitations_controller coverage and fixed some prob… #3152
Conversation
| @@ -0,0 +1,24 @@ | ||
| +require "spec_helper" |
| @@ -18,7 +18,7 @@ | ||
| context "Create Invite without email" do | ||
| let(:user) {build(:user)} | ||
| - let(:invite) {build(:invitation, invitee_email: user.email)} | ||
| + let(:invite) {build(:invitation, invitee_email: nil)} |
sarken
added
the
Awaiting review
label
Nov 11, 2017
|
It looks like this has acquired some merge conflicts that will need to be resolved before it can be reviewed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hatal175 commentedNov 10, 2017
…lems
Issue
https://otwarchive.atlassian.net/browse/AO3-4676
Purpose
This commit should extend coverage of invitations_controller to full. It also fixes a problem I ran into where a user could update his invitation to have an empty email and thus it goes into oblivion - the email is not sent but it does contain an empty string so it is not considered unsent.
I would like to request a review for invitation.rb to see it is a somewhat logical change in a system-side view.
Testing
Run normal tests and see coverage.
Credit
Tal Hayon
Please use he.