Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5043 Remove admin notifications feature #2941
Conversation
sarken
added some commits
Jun 15, 2017
sarken
added
the
Awaiting review
label
Jun 16, 2017
| @@ -1,23 +0,0 @@ | ||
| -<!--SEARCHBROWSE Descriptive page name, messages and instructions--> |
zz9pzza
Jun 20, 2017
Contributor
Should this file be removed ( it doesn't look relevant to the pull ? )
sarken
Jun 20, 2017
Owner
From the "purpose" bit:
It also removes the alphabet helper, which was used by the admin notifications feature and views/people/show.html.erb. views/people/show.html.erb is being removed here because it's not in use and was otherwise preventing the removal of the alphabet helper.
zz9pzza
added
Reviewed: Ready to Merge
and removed
Awaiting review
labels
Jun 20, 2017
zz9pzza
merged commit ec90e01
into
otwcode:master
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sarken commentedJun 16, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5043
Purpose
This removes the admin notifications feature and the corresponding "turn off admin emails" preference. It also removes the alphabet helper, which was used by the admin notifications feature and views/people/show.html.erb. views/people/show.html.erb is being removed here because it's not in use and was otherwise preventing the removal of the alphabet helper.
Testing
Refer to JIRA.